Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 503073002: roll harfbuzz 0d2c2f238bf0a847ecd55a70cc0f081f18a053ac:d457e3f0ff9b27616a34e4cc110d3edbf8796841 (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
behdad_google, behdad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/31e24d29f0654cbc08a62b06cdbf99791988229a Cr-Commit-Position: refs/heads/master@{#291707}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -28 lines) Patch
M third_party/harfbuzz-ng/README.chromium View 2 chunks +5 lines, -6 lines 0 comments Download
D third_party/harfbuzz-ng/google.patch View 1 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-font.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-fallback.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-win1256.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-private.hh View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Nico
6 years, 4 months ago (2014-08-25 16:51:33 UTC) #1
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-25 16:51:39 UTC) #2
Nico
The CQ bit was unchecked by thakis@chromium.org
6 years, 4 months ago (2014-08-25 16:51:44 UTC) #3
Nico
In patch set 2, I even remembered to delete google.patch.
6 years, 4 months ago (2014-08-25 16:52:19 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-25 16:52:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/503073002/20001
6 years, 4 months ago (2014-08-25 16:53:34 UTC) #6
behdad_google
lgtm My behdad@chromium.org account is b0rked and it has not been fixed yet, so I ...
6 years, 4 months ago (2014-08-25 17:11:28 UTC) #7
behdad_google
lgtm My behdad@chromium.org account is b0rked and it has not been fixed yet, so I ...
6 years, 4 months ago (2014-08-25 17:11:31 UTC) #8
Nico
On 2014/08/25 17:11:31, behdad_google wrote: > lgtm > > My mailto:behdad@chromium.org account is b0rked and ...
6 years, 4 months ago (2014-08-25 17:13:16 UTC) #9
Nico
Committed patchset #2 to pending queue manually as bb48873 (presubmit successful).
6 years, 4 months ago (2014-08-25 17:44:00 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:25 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31e24d29f0654cbc08a62b06cdbf99791988229a
Cr-Commit-Position: refs/heads/master@{#291707}

Powered by Google App Engine
This is Rietveld 408576698