Hangouts Remote Desktop Part VI - Show confirm dialog before retrieving access code

remoting/webapp/unittests/it2me_helpee_channel_unittest.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 
 'use strict';
 
 var hostInstaller = null;
 var hangoutPort = null;
@@ skipping 64 matching lines @@
     sinon.assert.calledWith(hangoutPort.postMessage, {
       method: MessageTypes.IS_HOST_INSTALLED_RESPONSE,
       result: false
     });
     QUnit.start();
   });
 });
 
 QUnit.asyncTest('isHostInstalled() should return true if host is installed',
     function() {
-  sinon.stub(hostInstaller, "isInstalled").returns(Promise.resolve(true));
+  sinon.stub(hostInstaller, 'isInstalled').returns(Promise.resolve(true));

[kelvinp, 2014/08/25 23:49:34]

The replacement of double quotes to single quotes technically doesn't belong to
this change.  But I think it is small enough that even if we need to revert the
current the CL, we won't loose much thing that is useful.  Therefore, I
incorporate that in this CL.

 
   var MessageTypes = remoting.It2MeHelpeeChannel.HangoutMessageTypes;
   hangoutPort.onMessage.mock$fire({
     method: MessageTypes.IS_HOST_INSTALLED
   });
 
   window.requestAnimationFrame(function() {
     sinon.assert.calledWith(hangoutPort.postMessage, {
       method: MessageTypes.IS_HOST_INSTALLED_RESPONSE,
       result: true
     });
     QUnit.start();
   });
 });
 
 test('downloadHost() should trigger a host download',
     function() {
-  sinon.stub(hostInstaller, "download").returns(Promise.resolve(true));
+  sinon.stub(hostInstaller, 'download').returns(Promise.resolve(true));
 
   hangoutPort.onMessage.mock$fire({
     method: remoting.It2MeHelpeeChannel.HangoutMessageTypes.DOWNLOAD_HOST
   });
 
   sinon.assert.called(hostInstaller.download);
 });
 
 test('connect() should return error if email is missing',
     function() {
   var MessageTypes = remoting.It2MeHelpeeChannel.HangoutMessageTypes;
 
   hangoutPort.onMessage.mock$fire({
     method: MessageTypes.CONNECT
   });
 
   sinon.assert.calledWithMatch(hangoutPort.postMessage, {
       method: MessageTypes.ERROR
   });
 });
 
 QUnit.asyncTest('connect() should return access code',
     function() {
   // Stubs authentication.
-  sinon.stub(base, "isAppsV2").returns(true);
-  sinon.stub(chrome.identity, "getAuthToken")
+  sinon.stub(base, 'isAppsV2').returns(true);
+  sinon.stub(remoting.MessageWindow, 'showConfirmWindow')
+      .callsArgWith(4, 1 /* 1 for OK. */);
+  sinon.stub(chrome.identity, 'getAuthToken')
       .callsArgWith(1, 'token');
   // Stubs Host behavior.
-  sinon.stub(host, "initialized").returns(true);
-  sinon.stub(host, "connect")
+  sinon.stub(host, 'initialized').returns(true);
+  sinon.stub(host, 'connect')
       .callsArgWith(2, remoting.HostSession.State.RECEIVED_ACCESS_CODE);
-  sinon.stub(host, "getAccessCode").returns('accessCode');
+  sinon.stub(host, 'getAccessCode').returns('accessCode');
 
   var MessageTypes = remoting.It2MeHelpeeChannel.HangoutMessageTypes;
   hangoutPort.onMessage.mock$fire({
     method: MessageTypes.CONNECT,
     email: 'test@chromium.org'
   });
 
   window.requestAnimationFrame(function(){
     // Verify that access code is correct in the response.
     sinon.assert.calledWithMatch(hangoutPort.postMessage, {
         method: MessageTypes.CONNECT_RESPONSE,
         accessCode: 'accessCode'
     });
 
     chrome.identity.getAuthToken.restore();
     base.isAppsV2.restore();
     QUnit.start();
   });
 });
 
 test('should disconnect the session if Hangout crashes', function() {
-  sinon.spy(host, "disconnect");
+  sinon.spy(host, 'disconnect');
   hangoutPort.onDisconnect.mock$fire();
 
   sinon.assert.called(onDisposedCallback);
   sinon.assert.called(host.disconnect);
 });
 
 })();