Hangouts Remote Desktop Part VI - Show confirm dialog before retrieving access code

Hangouts Remote Desktop Part VI - Show confirm dialog before retrieving access code

This dialog explains the implications of accepting remote 
assistance and provides a way for the user to decline 
assistance.  

This ensures that even if the caller (Hangouts) is compromised, 
it won't be able to control the user's desktop without user 
interaction.

BUG=405139
Committed: https://crrev.com/020970c9991637b98a034c4a23ec0fcbff35f01b
Cr-Commit-Position: refs/heads/master@{#293200}

[kelvinp, 2014-08-25 23:37:31]

kelvinp@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[kelvinp, 2014-08-25 23:42:57]

Patchset #2 (id:20001) has been deleted

[kelvinp, 2014-08-25 23:44:05]

Patchset #1 (id:1) has been deleted

[kelvinp, 2014-08-25 23:49:34]

kelvinp@chromium.org changed reviewers:
+ dcaiafa@chromium.org

[kelvinp, 2014-08-25 23:49:34]

PTAL

https://codereview.chromium.org/503063004/diff/40001/remoting/resources/remot...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/503063004/diff/40001/remoting/resources/remot...
remoting/resources/remoting_strings.grd:858: A participant in this hangout has
offered to help you by controlling your computer.  If you accept:
- The
person helping you will be able to control your mouse and keyboard.
- You
can end at any time.
This string comes from the existing confirm dialog from Hangouts remote
assistance.

https://codereview.chromium.org/503063004/diff/40001/remoting/webapp/unittest...
File remoting/webapp/unittests/it2me_helpee_channel_unittest.js (right):

https://codereview.chromium.org/503063004/diff/40001/remoting/webapp/unittest...
remoting/webapp/unittests/it2me_helpee_channel_unittest.js:85:
sinon.stub(hostInstaller, 'isInstalled').returns(Promise.resolve(true));
The replacement of double quotes to single quotes technically doesn't belong to
this change.  But I think it is small enough that even if we need to revert the
current the CL, we won't loose much thing that is useful.  Therefore, I
incorporate that in this CL.

[Jamie, 2014-08-26 00:54:21]

LGTM with string change (I'm happy to review again if you want to sanity-check
that).

https://codereview.chromium.org/503063004/diff/60001/remoting/resources/remot...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/503063004/diff/60001/remoting/resources/remot...
remoting/resources/remoting_strings.grd:858: A participant in this hangout has
offered to help you by controlling your computer.  If you accept:
- The
person helping you will be able to control your mouse and keyboard.
- You
can end at any time.
This should be broken down into multiple messages and rendered using <ul>. Or
just rephrase it to be a single sentence. Embedded line-breaks and dashes
instead of bullets give a poor UX.

https://codereview.chromium.org/503063004/diff/60001/remoting/webapp/unittest...
File remoting/webapp/unittests/base_unittest.js (right):

https://codereview.chromium.org/503063004/diff/60001/remoting/webapp/unittest...
remoting/webapp/unittests/base_unittest.js:81:
'&lt;script&gt;alert("hello")&lt;/script&gt;');
Are there any other characters that should be escaped?

https://codereview.chromium.org/503063004/diff/60001/remoting/webapp/unittest...
File remoting/webapp/unittests/it2me_helpee_channel_unittest.js (right):

https://codereview.chromium.org/503063004/diff/60001/remoting/webapp/unittest...
remoting/webapp/unittests/it2me_helpee_channel_unittest.js:154:
remoting.MessageWindow.showConfirmWindow.restore();
Not directly related to this CL, but this approach of explicitly restoring the
stubs at the end of each test feels fragile. For example, it will break if there
is an exception or an early return in the test. In this case it's doubly
confusing because the restore calls occur inside an asynchronous callback.
Perhaps in a future CL we can come up with some framework to make it easier to
remove stubs automatically when a test is torn down?

[kelvinp, 2014-09-03 18:12:03]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2014-09-03 18:12:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kelvinp@chromium.org/503063004/80001

[commit-bot: I haz the power, 2014-09-03 19:08:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/49677)

[commit-bot: I haz the power, 2014-09-03 21:34:39]

Committed patchset #3 (id:80001) as 25cb0751bd6418be7a835078b6d05e68fd267d09

[commit-bot: I haz the power, 2014-09-10 03:27:54]

Patchset 3 (id:??) landed as
https://crrev.com/020970c9991637b98a034c4a23ec0fcbff35f01b
Cr-Commit-Position: refs/heads/master@{#293200}