Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 503061: Merge 34957 - Fixes crash when message IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY... (Closed)

Created:
11 years ago by Nebojša Ćirić
Modified:
9 years, 7 months ago
Reviewers:
Nebojša Ćirić
CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 34957 - Fixes crash when message IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW has nonASCII characters. BUG=30736 TEST=Open chrome with lang=sr and try to pack extension. It shouldn't crash, and files with be generated. Review URL: http://codereview.chromium.org/503051 TBR=cira@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/extensions/extensions_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nebojša Ćirić
11 years ago (2009-12-18 23:29:04 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698