Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 503053005: Add Suites results to Speedometer (Closed)

Created:
6 years, 4 months ago by fmeawad
Modified:
6 years, 3 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add Suites results to Speedometer Display the results for the individual benchmark suites, this is acheived by storing the full results set and quering it after the benchmark has finished. BUG=389257 Committed: https://crrev.com/14014307773800b452b475c15b7860039114314a Cr-Commit-Position: refs/heads/master@{#291848}

Patch Set 1 #

Patch Set 2 : Remove debugging code #

Total comments: 4

Patch Set 3 : nit fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M tools/perf/benchmarks/speedometer.py View 1 2 1 chunk +32 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
fmeawad
fmeawad@chromium.org changed reviewers: + dtu@chromium.org, tonyg@chromium.org
6 years, 4 months ago (2014-08-25 22:27:00 UTC) #1
fmeawad
I injected a script that keeps the results around, and then queried those results at ...
6 years, 4 months ago (2014-08-25 22:27:00 UTC) #2
tonyg
lgtm w/ nits https://codereview.chromium.org/503053005/diff/20001/tools/perf/benchmarks/speedometer.py File tools/perf/benchmarks/speedometer.py (right): https://codereview.chromium.org/503053005/diff/20001/tools/perf/benchmarks/speedometer.py#newcode43 tools/perf/benchmarks/speedometer.py:43: benchmarkClient.didRunSuites = function (measuredValues) { uber-nit: ...
6 years, 4 months ago (2014-08-25 22:32:13 UTC) #3
fmeawad
https://codereview.chromium.org/503053005/diff/20001/tools/perf/benchmarks/speedometer.py File tools/perf/benchmarks/speedometer.py (right): https://codereview.chromium.org/503053005/diff/20001/tools/perf/benchmarks/speedometer.py#newcode43 tools/perf/benchmarks/speedometer.py:43: benchmarkClient.didRunSuites = function (measuredValues) { On 2014/08/25 22:32:13, tonyg ...
6 years, 4 months ago (2014-08-25 22:49:24 UTC) #4
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-25 22:51:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmeawad@chromium.org/503053005/40001
6 years, 4 months ago (2014-08-25 22:53:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 01:52:48 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
6 years, 4 months ago (2014-08-26 01:52:48 UTC) #8
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-26 03:12:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmeawad@chromium.org/503053005/40001
6 years, 4 months ago (2014-08-26 03:13:41 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 03:15:06 UTC) #11
commit-bot: I haz the power
Failed to commit the patch.
6 years, 4 months ago (2014-08-26 03:15:07 UTC) #12
fmeawad
The CQ bit was checked by fmeawad@chromium.org
6 years, 4 months ago (2014-08-26 05:35:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmeawad@chromium.org/503053005/40001
6 years, 4 months ago (2014-08-26 05:36:23 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (40001) as ddf514b0c8b99c37149005a2b79f507060da948f
6 years, 4 months ago (2014-08-26 05:37:19 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:40:46 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/14014307773800b452b475c15b7860039114314a
Cr-Commit-Position: refs/heads/master@{#291848}

Powered by Google App Engine
This is Rietveld 408576698