Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 503053004: Update V8 to version 3.29.17 (based on bleeding_edge revision r23372). (Closed)

Created:
6 years, 3 months ago by Michael Achenbach
Modified:
6 years, 3 months ago
Reviewers:
acleung1, vogelheim
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 3.29.17 (based on bleeding_edge revision r23372). TBR=vogelheim@chromium.org NOTRY=true Committed: https://crrev.com/d58e46c12494cc3b0ce541624f1c54fe2f7e2a1e Cr-Commit-Position: refs/heads/master@{#291857}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Michael Achenbach
6 years, 3 months ago (2014-08-25 20:11:36 UTC) #1
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 3 months ago (2014-08-25 20:11:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/503053004/1
6 years, 3 months ago (2014-08-25 20:12:42 UTC) #3
Michael Achenbach
FYI: Fixes mips.
6 years, 3 months ago (2014-08-25 20:14:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-25 23:40:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 00:19:38 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-26 00:19:39 UTC) #7
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 3 months ago (2014-08-26 06:43:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/503053004/20001
6 years, 3 months ago (2014-08-26 06:44:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (20001) as 3e6a9de20821338ca9d44872e4785bb3faa3516a
6 years, 3 months ago (2014-08-26 06:45:30 UTC) #10
vogelheim
lgtm
6 years, 3 months ago (2014-08-26 08:45:22 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d58e46c12494cc3b0ce541624f1c54fe2f7e2a1e
Cr-Commit-Position: refs/heads/master@{#291857}

Powered by Google App Engine
This is Rietveld 408576698