Move ExtensionWarningService and ExtensionsWarningSet to extensions.

extensions/browser/extension_warning_set.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_WARNING_SET_H_
-#define CHROME_BROWSER_EXTENSIONS_EXTENSION_WARNING_SET_H_
+#ifndef EXTENSIONS_BROWSER_EXTENSION_WARNING_SET_H_
+#define EXTENSIONS_BROWSER_EXTENSION_WARNING_SET_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "url/gurl.h"
 
 // TODO(battre) Remove the Extension prefix.
 
 namespace base {
 class FilePath;
 }
 
 namespace extensions {
 
 class ExtensionSet;
 
 // This class is used by the ExtensionWarningService to represent warnings if
 // extensions misbehave. Note that the ExtensionWarningService deals only with
 // specific warnings that should trigger a badge on the Chrome menu button.
 class ExtensionWarning {

[James Cook, 2014/08/25 20:58:12]

It would be a little weird to have a class named just "extensions::Warning" but
that might be OK.

extensions::WarningSet works for me.

Again, I'd ask Fady for his opinion. In general I'm in favor of shorter names
when the code lives in src/extensions and the namespace is extensions::

[Fady Samuel, 2014/08/25 21:15:38]

+1 to extensions::WarningSet.

[Xi Han, 2014/08/26 18:21:40]

Since an ExtensionWarningSet is defined at the end of this file, I will rename
in the following way:
-ExtensionWarning will become Warning &
-ExtensionWarningSet will become WarningSet.

  public:
   enum WarningType {
     // Don't use this, it is only intended for the default constructor and
     // does not have localized warning messages for the UI.
     kInvalid = 0,
     // An extension caused excessive network delays.
     kNetworkDelay,
     // This extension failed to modify a network request because the
     // modification conflicted with a modification of another extension.
     kNetworkConflict,
@@ skipping 76 matching lines @@
 
 // Compare ExtensionWarnings based on the tuple of (extension_id, type).
 // The message associated with ExtensionWarnings is purely informational
 // and does not contribute to distinguishing extensions.
 bool operator<(const ExtensionWarning& a, const ExtensionWarning& b);
 
 typedef std::set<ExtensionWarning> ExtensionWarningSet;
 
 }  // namespace extensions
 
-#endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_WARNING_SET_H_
+#endif  // EXTENSIONS_BROWSER_EXTENSION_WARNING_SET_H_