Move ExtensionWarningService and ExtensionsWarningSet to extensions.

extensions/browser/extension_warning_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_WARNING_SERVICE_H_
-#define CHROME_BROWSER_EXTENSIONS_EXTENSION_WARNING_SERVICE_H_
+#ifndef EXTENSIONS_BROWSER_EXTENSION_WARNING_SERVICE_H_
+#define EXTENSIONS_BROWSER_EXTENSION_WARNING_SERVICE_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/observer_list.h"
 #include "base/scoped_observer.h"
 #include "base/threading/non_thread_safe.h"
-#include "chrome/browser/extensions/extension_warning_set.h"
 #include "extensions/browser/extension_registry_observer.h"
+#include "extensions/browser/extension_warning_set.h"
 
 // TODO(battre) Remove the Extension prefix.
 
-class Profile;
-
 namespace content {
 class NotificationDetails;

[James Cook, 2014/08/25 20:58:11]

nit: forward declare BrowserContext, even though some other header above
probably declares it

[Xi Han, 2014/08/26 18:21:40]

Done.

 class NotificationSource;
 }
 
 namespace extensions {
 
 class ExtensionRegistry;
 
 // Manages a set of warnings caused by extensions. These warnings (e.g.
 // conflicting modifications of network requests by extensions, slow extensions,
 // etc.) trigger a warning badge in the UI and and provide means to resolve
 // them. This class must be used on the UI thread only.
 class ExtensionWarningService : public ExtensionRegistryObserver,

[James Cook, 2014/08/25 20:58:11]

Did you consider renaming this class to just "WarningService", since it could be
referred to as extensions::WarningService?  See battre's comment above. Now
would be a good time to do that, since you already have to touch every file that
includes this header.

I would get Fady's opinion, though.

[Fady Samuel, 2014/08/25 21:15:38]

I agree, it makes sense to do the rename.

                                 public base::NonThreadSafe {
  public:
   class Observer {
    public:
     virtual void ExtensionWarningsChanged() = 0;
   };
 
-  // |profile| may be NULL for testing. In this case, be sure to not insert
-  // any warnings.
-  explicit ExtensionWarningService(Profile* profile);
+  // |browser_context| may be NULL for testing. In this case, be sure to not
+  // insert any warnings.
+  explicit ExtensionWarningService(content::BrowserContext* browser_context);
   virtual ~ExtensionWarningService();
 
   // Clears all warnings of types contained in |types| and notifies observers
   // of the changed warnings.
   void ClearWarnings(const std::set<ExtensionWarning::WarningType>& types);
 
   // Returns all types of warnings effecting extension |extension_id|.
   std::set<ExtensionWarning::WarningType> GetWarningTypesAffectingExtension(
       const std::string& extension_id) const;
 
   // Returns all localized warnings for extension |extension_id| in |result|.
   std::vector<std::string> GetWarningMessagesForExtension(
       const std::string& extension_id) const;
 
   const ExtensionWarningSet& warnings() const { return warnings_; }
 
   // Adds a set of warnings and notifies observers if any warning is new.
   void AddWarnings(const ExtensionWarningSet& warnings);
 
-  // Notifies the ExtensionWarningService of profile |profile_id| that new
-  // |warnings| occurred and triggers a warning badge.
+  // Notifies the ExtensionWarningService of browser_context |profile_id| that

[James Cook, 2014/08/25 20:58:11]

I might rename profile_id to browser_context_id.

[Xi Han, 2014/08/26 18:21:40]

Done.

+  // new |warnings| occurred and triggers a warning badge.
   static void NotifyWarningsOnUI(void* profile_id,
                                  const ExtensionWarningSet& warnings);
 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
  private:
   void NotifyWarningsChanged();
 
   // ExtensionRegistryObserver implementation.
   virtual void OnExtensionUnloaded(content::BrowserContext* browser_context,
                                    const Extension* extension,
                                    UnloadedExtensionInfo::Reason reason)
       OVERRIDE;
 
   // Currently existing warnings.
   ExtensionWarningSet warnings_;
 
-  Profile* profile_;
+  content::BrowserContext* browser_context_;

[Fady Samuel, 2014/08/25 21:15:38]

Does it make sense to make this const?

content::BrowserContext* const browser_context_;

This makes it clear that this member variable will not change in the lifetime of
this object.

[Xi Han, 2014/08/26 18:21:40]

Done.

 
   // Listen to extension unloaded notifications.
   ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
       extension_registry_observer_;
 
   ObserverList<Observer> observer_list_;
 };
 
 }  // namespace extensions
 
-#endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_WARNING_SERVICE_H_
+#endif  // EXTENSIONS_BROWSER_EXTENSION_WARNING_SERVICE_H_