Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 50303007: Move test-only stuff from cc/debug/ to cc/test (Closed)

Created:
7 years, 1 month ago by jamesr
Modified:
7 years, 1 month ago
Reviewers:
danakj, piman
CC:
chromium-reviews, jbauman+watch_chromium.org, Ian Vollick, jam, sievers+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Move test-only stuff from cc/debug/ to cc/test This moves the test/fake context implementations from cc/debug/ to cc/test and stops linking them into production targets. Test targets elsewhere in the tree can link against cc_test_support to use these. R=danakj,piman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232025

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : fix aura component builds #

Patch Set 6 : fold cc_test_utils into cc_test_support to fix windows link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -2668 lines) Patch
M cc/cc.gyp View 3 chunks +0 lines, -12 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 4 5 6 chunks +34 lines, -34 lines 0 comments Download
D cc/debug/fake_web_graphics_context_3d.h View 1 chunk +0 lines, -617 lines 0 comments Download
D cc/debug/fake_web_graphics_context_3d.cc View 1 chunk +0 lines, -373 lines 0 comments Download
D cc/debug/ordered_texture_map.h View 1 chunk +0 lines, -46 lines 0 comments Download
D cc/debug/ordered_texture_map.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D cc/debug/test_context_provider.h View 1 chunk +0 lines, -90 lines 0 comments Download
D cc/debug/test_context_provider.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D cc/debug/test_context_support.h View 1 1 chunk +0 lines, -37 lines 0 comments Download
D cc/debug/test_context_support.cc View 1 1 chunk +0 lines, -36 lines 0 comments Download
D cc/debug/test_texture.h View 1 chunk +0 lines, -39 lines 0 comments Download
D cc/debug/test_texture.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D cc/debug/test_web_graphics_context_3d.h View 1 1 chunk +0 lines, -323 lines 0 comments Download
D cc/debug/test_web_graphics_context_3d.cc View 1 1 chunk +0 lines, -665 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M cc/layers/texture_layer_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M cc/output/gl_renderer_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M cc/output/output_surface_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/shader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/raster_worker_pool_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/resources/resource_update_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/texture_mailbox_deleter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/video_resource_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/texture_uploader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_layer_tree_host_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_output_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + cc/test/fake_web_graphics_context_3d.h View 2 chunks +4 lines, -7 lines 0 comments Download
A + cc/test/fake_web_graphics_context_3d.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_web_graphics_context_3d_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 2 chunks +1 line, -1 line 0 comments Download
A + cc/test/ordered_texture_map.h View 2 chunks +4 lines, -5 lines 0 comments Download
A + cc/test/ordered_texture_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + cc/test/test_context_provider.h View 3 chunks +6 lines, -8 lines 0 comments Download
A + cc/test/test_context_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + cc/test/test_context_support.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + cc/test/test_context_support.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + cc/test/test_texture.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + cc/test/test_texture.cc View 1 chunk +1 line, -1 line 0 comments Download
A + cc/test/test_web_graphics_context_3d.h View 1 3 chunks +7 lines, -8 lines 0 comments Download
A + cc/test/test_web_graphics_context_3d.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.gyp View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M ui/compositor/test/test_context_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
jamesr
Finally! Depends on https://codereview.chromium.org/45963003/
7 years, 1 month ago (2013-10-30 00:37:15 UTC) #1
jamesr
BTW, I need this to introduce a GLES2Interface to cc:: to start using in tests. ...
7 years, 1 month ago (2013-10-30 00:38:43 UTC) #2
jamesr
This + https://codereview.chromium.org/45963003/ appears to save around 100k of binary in a release linux aura ...
7 years, 1 month ago (2013-10-30 00:47:03 UTC) #3
piman
lgtm
7 years, 1 month ago (2013-10-30 04:49:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/50303007/100001
7 years, 1 month ago (2013-10-30 19:43:29 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-10-30 20:05:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/50303007/100001
7 years, 1 month ago (2013-10-30 20:24:21 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-10-30 20:50:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/50303007/320001
7 years, 1 month ago (2013-10-30 21:16:51 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-10-30 21:38:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/50303007/320001
7 years, 1 month ago (2013-10-30 21:45:18 UTC) #11
jamesr
failed on win_x64_rel: FAILED: cmd /c E:\b\depot_tools\python_bin\python.exe gyp-win-tool link-wrapper environment.x64 link.exe /nologo /OUT:interactive_ui_tests.exe /PDB:interactive_ui_tests.exe.pdb @interactive_ui_tests.exe.rsp ...
7 years, 1 month ago (2013-10-31 00:39:00 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-10-31 00:41:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/50303007/300002
7 years, 1 month ago (2013-10-31 00:43:22 UTC) #14
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 06:55:02 UTC) #15
Message was sent while issue was closed.
Change committed as 232025

Powered by Google App Engine
This is Rietveld 408576698