Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 503023: Adds the cmdline "--new-window" that instructs the init sequence... (Closed)

Created:
11 years ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
clemens
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Adds the cmdline "--new-window" that instructs the init sequence to open a new window instead of reusing the most recent tab for opening cmdline URLs. BUG=2843 TEST=Run with --new-window switch and confirm that a new window pops up patch by <clemens [at] endorphin dot org> original review: <http://codereview.chromium.org/464060>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34926

Patch Set 1 #

Patch Set 2 : AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_init.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
Clemens, can you confirm that the AUTHORS file is correct? Also notice I changed the ...
11 years ago (2009-12-16 01:33:02 UTC) #1
clemens
On 2009/12/16 01:33:02, Evan Stade wrote: > Clemens, can you confirm that the AUTHORS file ...
11 years ago (2009-12-16 08:05:11 UTC) #2
Evan Stade
11 years ago (2009-12-16 19:49:10 UTC) #3
> > Also notice I changed the flag string slightly.
> 
> What about replacing the string with something like
> "--disposition=new-window"? As far as I can see on
>
http://groups.google.com/group/chromium-reviews/browse_thread/thread/f617e641...
> PK won't provide a patch for disposition, as he stopped pushing for that.
> However, using a switch name like this would give as forward compatibility in
> case we change our minds.
> 
> (Although I'm totally fine with using only --new-window)

I thought of that, but it made me go "meh". But if you want to whip up that
patch I'd LG that as well.

Powered by Google App Engine
This is Rietveld 408576698