Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Unified Diff: src/debug.cc

Issue 503022: Add locker support to DebugMessageDispatchHandler (Closed)
Patch Set: make compilable with debugger support off Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/v8threads.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index fbe09391e27fabe4c9934adb79463a57288565ab..6b01d98cf01a784b56c9da6e6c6fddfb191e2383 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -2438,8 +2438,16 @@ void Debugger::ProcessCommand(Vector<const uint16_t> command,
StackGuard::DebugCommand();
}
- if (Debugger::debug_message_dispatch_handler_ != NULL) {
- Debugger::debug_message_dispatch_handler_();
+ {
+ // TODO: Lock only optionally
+ LockParameters lock_params;
+ Locker lock(&lock_params);
+ if (lock_params.successfully_relaied) {
+ } else {
+ if (Debugger::debug_message_dispatch_handler_ != NULL) {
+ Debugger::debug_message_dispatch_handler_();
+ }
+ }
}
}
« no previous file with comments | « src/api.cc ('k') | src/v8threads.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698