Issue 502993003: DeviceSettingsProvider::Decode*() methods are moved out to the anonymous namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 502993003: DeviceSettingsProvider::Decode*() methods are moved out to the anonymous namespace. (Closed)

Created:
6 years, 4 months ago by ygorshenin1

Modified:
6 years, 3 months ago

Reviewers:
pastarmovj

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DeviceSettingsProvider::Decode*() methods are moved out to the anonymous namespace. The purpose of the CL is to simplify DeviceSettingsProvider API, as Set() path should be moved out. BUG=230018 TEST=none Committed: https://crrev.com/694731dca94df5c2dbe48bc26368149a59ef5e05 Cr-Commit-Position: refs/heads/master@{#291884}

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+432 lines, -452 lines)			Patch
	M	chrome/browser/chromeos/settings/device_settings_provider.h	View		1 chunk	+0 lines, -20 lines	0 comments	Download
	M	chrome/browser/chromeos/settings/device_settings_provider.cc	View		2 chunks	+432 lines, -432 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/502993003/1

6 years, 3 months ago (2014-08-26 09:11:38 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (1) as ed2f808d677f40bd6f5bb17297e4932fe75477d5

6 years, 3 months ago (2014-08-26 11:21:15 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:42:07 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/694731dca94df5c2dbe48bc26368149a59ef5e05
Cr-Commit-Position: refs/heads/master@{#291884}

Expand Messages | Collapse Messages