Issue 502993002: Updating MakeMenuItemStringsFor() to include separators in custom items

Issue 502993002: Updating MakeMenuItemStringsFor() to include separators in custom items (Closed)

Created:
6 years, 3 months ago by pals

Modified:
6 years, 3 months ago

Reviewers:
tkent

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Updating MakeMenuItemStringsFor() to include separators in custom items BUG=87553 Committed: https://crrev.com/362c3256e3e4d65a80185e12932cabd304cfc2f9 Cr-Commit-Position: refs/heads/master@{#291867}

Patch Set 2 : Making separator look special #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	content/shell/renderer/test_runner/event_sender.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

pals

PTAL. This change is required to test separator as mentioned in the specification http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#menu-builder.

6 years, 3 months ago (2014-08-25 12:43:50 UTC) #1

tkent

lgtm https://codereview.chromium.org/502993002/diff/1/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/502993002/diff/1/content/shell/renderer/test_runner/event_sender.cc#newcode127 content/shell/renderer/test_runner/event_sender.cc:127: const char kSeparatorIdentifier[] = "Separator"; I prefer that ...

6 years, 3 months ago (2014-08-25 20:20:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/502993002/60001

6 years, 3 months ago (2014-08-26 05:31:06 UTC) #6

commit-bot: I haz the power

Committed patchset #2 (60001) as d6bae872488984db43f511af5aa355eaa838feca

6 years, 3 months ago (2014-08-26 08:07:25 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:41:25 UTC) #8

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/362c3256e3e4d65a80185e12932cabd304cfc2f9
Cr-Commit-Position: refs/heads/master@{#291867}

Expand Messages | Collapse Messages