Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: storage/browser/fileapi/file_stream_writer.h

Issue 502973005: [fsp] Buffer consecutive Write() calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: storage/browser/fileapi/file_stream_writer.h
diff --git a/storage/browser/fileapi/file_stream_writer.h b/storage/browser/fileapi/file_stream_writer.h
index ec59ec0f84d6111826c95dab54f2761a3c66044c..c0771002ffa7d1a8d62e6d5d0220203163265c5f 100644
--- a/storage/browser/fileapi/file_stream_writer.h
+++ b/storage/browser/fileapi/file_stream_writer.h
@@ -46,6 +46,10 @@ class FileStreamWriter {
// callback will be run on the thread where Write() was called when the write
// has completed.
//
+ // After the last write, Flush() must be called unless the flushing on
+ // completion is explicitly disabled for the file system type, the writer is
+ // created for. See FileSystemContext::ShouldFlushOnWriteCompletion().
+ //
// This errors out (either synchronously or via callback) with:
// net::ERR_FILE_NOT_FOUND: When the target file is not found.
// net::ERR_ACCESS_DENIED: When the target file is a directory or
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698