chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc - Issue 502973005: [fsp] Buffer consecutive Write() calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc

Issue 502973005: [fsp] Buffer consecutive Write() calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_writer_unittest.cc ('k') | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc

diff --git a/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc b/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc

index 6441cfba5c2f82be4e0fa8550869c4262a2dd097..3290129a4db4dc697982830d48e8b00a2f6fa4f6 100644

--- a/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc

+++ b/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc

@@ -6,6 +6,7 @@

#include "base/debug/trace_event.h"

#include "base/memory/ref_counted.h"

+#include "base/thread_task_runner_handle.h"

#include "chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.h"

#include "chrome/browser/chromeos/file_system_provider/mount_path_util.h"

#include "chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h"

@@ -272,10 +273,11 @@ int FileStreamWriter::Cancel(const net::CompletionCallback& callback) {

}

int FileStreamWriter::Flush(const net::CompletionCallback& callback) {

- if (state_ != INITIALIZED)

- return net::ERR_FAILED;

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

+ FROM_HERE,

+ base::Bind(callback, state_ == INITIALIZED ? net::OK : net::ERR_FAILED));

- return net::OK;

+ return net::ERR_IO_PENDING;

}

void FileStreamWriter::OnWriteFileCompleted(