Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 502953003: Added support for re-running of layout tests form the dashboard. (Closed)

Created:
6 years, 4 months ago by patro
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adding support for re-running of layout tests form the dashboard. This allows the developer the ease of selecting specific layout tests which they want to re run from the convinience of a web page instead of terminal. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182377

Patch Set 1 : Working Patch #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Working Patch using BaseHttpServer #

Patch Set 5 : Addressing Comments #

Total comments: 2

Patch Set 6 : Addressing comment #

Patch Set 7 : Fixing Failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -11 lines) Patch
M LayoutTests/fast/harness/archived-results-dashboard.html View 1 2 3 4 3 chunks +61 lines, -2 lines 0 comments Download
M LayoutTests/fast/harness/resources/archived-results-dashboard-test.js View 1 2 3 4 5 6 1 chunk +9 lines, -9 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/__init__.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A Tools/Scripts/webkitpy/tool/commands/layouttestsserver.py View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download
A Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py View 1 2 3 4 5 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (6 generated)
vivekg
Please add some unit tests for supported actions, running port etc. for the new functionality.
6 years, 3 months ago (2014-08-26 11:05:13 UTC) #1
patro
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-26 11:11:25 UTC) #2
patro
behara.ms@samsung.com changed reviewers: + dpranke@chromium.org
6 years, 3 months ago (2014-08-26 15:02:46 UTC) #3
patro
Kindly Review Thanks, Shyam Patro
6 years, 3 months ago (2014-09-01 14:25:36 UTC) #4
Dirk Pranke
Using websockets for this seems kinda goofy, particularly since this is basically a single RPC ...
6 years, 3 months ago (2014-09-03 00:01:31 UTC) #5
patro
On 2014/09/03 00:01:31, Dirk Pranke wrote: > Using websockets for this seems kinda goofy, particularly ...
6 years, 3 months ago (2014-09-10 12:55:04 UTC) #6
Dirk Pranke
On 2014/09/10 12:55:04, patro wrote: > On 2014/09/03 00:01:31, Dirk Pranke wrote: > > Using ...
6 years, 3 months ago (2014-09-10 20:17:31 UTC) #7
patro
On 2014/09/10 20:17:31, Dirk Pranke wrote: > On 2014/09/10 12:55:04, patro wrote: > > On ...
6 years, 3 months ago (2014-09-12 14:34:44 UTC) #10
Dirk Pranke
okay, this looks generally close to right. For consistency with the other servers, though, it'd ...
6 years, 3 months ago (2014-09-12 18:43:05 UTC) #11
patro
On 2014/09/12 18:43:05, Dirk Pranke wrote: > okay, this looks generally close to right. > ...
6 years, 3 months ago (2014-09-19 10:32:51 UTC) #13
Dirk Pranke
lgtm. Thanks for bearing with me! https://codereview.chromium.org/502953003/diff/140001/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py File Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py (right): https://codereview.chromium.org/502953003/diff/140001/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py#newcode51 Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py:51: # Fixme : ...
6 years, 3 months ago (2014-09-19 18:34:26 UTC) #14
patro
https://codereview.chromium.org/502953003/diff/140001/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py File Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py (right): https://codereview.chromium.org/502953003/diff/140001/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py#newcode51 Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py:51: # Fixme : Has to be json object On ...
6 years, 3 months ago (2014-09-20 17:11:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/502953003/160001
6 years, 3 months ago (2014-09-20 17:11:56 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/25727)
6 years, 3 months ago (2014-09-20 18:11:16 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/502953003/180001
6 years, 3 months ago (2014-09-21 18:42:55 UTC) #21
commit-bot: I haz the power
6 years, 3 months ago (2014-09-21 19:16:53 UTC) #22
Message was sent while issue was closed.
Committed patchset #7 (id:180001) as 182377

Powered by Google App Engine
This is Rietveld 408576698