Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: runtime/lib/array.cc

Issue 502953002: Implement native _List. constructor in the flow-graph builder. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/assert.h" 5 #include "platform/assert.h"
6 #include "vm/bootstrap_natives.h" 6 #include "vm/bootstrap_natives.h"
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/bigint_operations.h" 8 #include "vm/bigint_operations.h"
9 #include "vm/exceptions.h" 9 #include "vm/exceptions.h"
10 #include "vm/native_entry.h" 10 #include "vm/native_entry.h"
11 #include "vm/object.h" 11 #include "vm/object.h"
12 12
13 namespace dart { 13 namespace dart {
14 14
15 DEFINE_NATIVE_ENTRY(List_allocate, 2) { 15 DEFINE_NATIVE_ENTRY(List_allocate, 2) {
16 const TypeArguments& type_arguments = 16 // Implemented in FlowGraphBuilder::VisitNativeBody.
17 TypeArguments::CheckedHandle(isolate, arguments->NativeArgAt(0)); 17 UNREACHABLE();
18 const Instance& length = Instance::CheckedHandle( 18 return Object::null();
19 isolate, arguments->NativeArgAt(1));
20 if (!length.IsSmi()) {
21 const String& error = String::Handle(String::NewFormatted(
22 "Length must be an integer in the range [0..%" Pd "].",
23 Array::kMaxElements));
24 Exceptions::ThrowArgumentError(error);
25 }
26 intptr_t len = Smi::Cast(length).Value();
27 if (len < 0 || len > Array::kMaxElements) {
28 const String& error = String::Handle(String::NewFormatted(
29 "Length (%" Pd ") must be an integer in the range [0..%" Pd "].",
30 len, Array::kMaxElements));
31 Exceptions::ThrowArgumentError(error);
32 }
33 const Array& new_array = Array::Handle(Array::New(len));
34 new_array.SetTypeArguments(type_arguments);
35 return new_array.raw();
36 } 19 }
37 20
38 21
39 DEFINE_NATIVE_ENTRY(List_getIndexed, 2) { 22 DEFINE_NATIVE_ENTRY(List_getIndexed, 2) {
40 const Array& array = Array::CheckedHandle(arguments->NativeArgAt(0)); 23 const Array& array = Array::CheckedHandle(arguments->NativeArgAt(0));
41 GET_NON_NULL_NATIVE_ARGUMENT(Smi, index, arguments->NativeArgAt(1)); 24 GET_NON_NULL_NATIVE_ARGUMENT(Smi, index, arguments->NativeArgAt(1));
42 if ((index.Value() < 0) || (index.Value() >= array.Length())) { 25 if ((index.Value() < 0) || (index.Value() >= array.Length())) {
43 const Array& args = Array::Handle(Array::New(1)); 26 const Array& args = Array::Handle(Array::New(1));
44 args.SetAt(0, index); 27 args.SetAt(0, index);
45 Exceptions::ThrowByType(Exceptions::kRange, args); 28 Exceptions::ThrowByType(Exceptions::kRange, args);
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 Object& temp = Object::Handle(); 106 Object& temp = Object::Handle();
124 for (intptr_t i = 0; i < length; i++) { 107 for (intptr_t i = 0; i < length; i++) {
125 temp = from_array.At(i + offset); 108 temp = from_array.At(i + offset);
126 result.SetAt(i, temp); 109 result.SetAt(i, temp);
127 } 110 }
128 result.MakeImmutable(); 111 result.MakeImmutable();
129 return result.raw(); 112 return result.raw();
130 } 113 }
131 114
132 } // namespace dart 115 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698