Issue 50293009: Revert r231888 "Fixes for python 2.7.5 support."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 50293009: Revert r231888 "Fixes for python 2.7.5 support." (Closed)

Created:
7 years, 1 month ago by M-A Ruel

Modified:
7 years, 1 month ago

Reviewers:
iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Revert r231888 "Fixes for python 2.7.5 support." This broke git cl patch due to escaping. I tried removing the double quotes but it didn't work out. Reverting in the meantime to unblock people until I figure out a permanent way. BUG=313552, 241769 TBR=iannucci Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=232112

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	.gitignore	View	1 chunk	+1 line, -1 line	0 comments	Download
M	PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	git-cl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	git-try	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pylint	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/50293009/1

7 years, 1 month ago (2013-10-31 14:23:14 UTC) #2

iannucci

7 years, 1 month ago (2013-10-31 17:22:28 UTC) #4

Message was sent while issue was closed.

On 2013/10/31 14:25:20, I haz the power (commit-bot) wrote:
> Change committed as 232112

lgtm. quoting sucks :(

I'm assuming the "$@" at the end didn't work for some reason?? (that looks like
the right invocation to me...)

Expand Messages | Collapse Messages