Issue 50293006: Enable correct behaviour for deleting regional indicator symbols on Android OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 50293006: Enable correct behaviour for deleting regional indicator symbols on Android OS (Closed)

Created:
7 years, 1 month ago by wolanski

Modified:
7 years, 1 month ago

Reviewers:
lgombos, eae

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Enable correct behaviour for deleting regional indicator symbols on Android OS Regional indicator symbols that are combined should behave as a single character when deleting. BUG=313656 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161191

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Source/core/rendering/RenderText.cpp	View		3 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/k.wolanski@samsung.com/50293006/1

7 years, 1 month ago (2013-11-01 17:59:48 UTC) #3

lgombos

7 years, 1 month ago (2013-11-01 19:13:20 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/50293006/diff/1/Source/core/rendering/RenderT...
File Source/core/rendering/RenderText.cpp (right):

https://codereview.chromium.org/50293006/diff/1/Source/core/rendering/RenderT...
Source/core/rendering/RenderText.cpp:1656: #if OS(MACOSX) || OS(POSIX)
This can and should be changed to #if OS(POSIX).

Expand Messages | Collapse Messages