extensions/renderer/api/serial/serial_api_unittest.cc - Issue 502893002: Fix some leaks and failures under valgrind in JS extensions unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api/serial/serial_api_unittest.cc

Issue 502893002: Fix some leaks and failures under valgrind in JS extensions unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/api/serial/serial_api_unittest.cc

diff --git a/extensions/renderer/api/serial/serial_api_unittest.cc b/extensions/renderer/api/serial/serial_api_unittest.cc

index 530ce2e93b0ed0383d1b78dabfefe3656b3ab167..7f44878b907886aeb0d4114d5c3e3d0103830863 100644

--- a/extensions/renderer/api/serial/serial_api_unittest.cc

+++ b/extensions/renderer/api/serial/serial_api_unittest.cc

@@ -313,12 +313,6 @@ class SerialApiTest : public ApiTestBase {

&SerialApiTest::CreateSerialService, base::Unretained(this)));

}

- virtual void TearDown() OVERRIDE {

- if (io_handler_)

- EXPECT_TRUE(io_handler_->HasOneRef());

- ApiTestBase::TearDown();

- }

scoped_refptr<TestIoHandlerBase> io_handler_;

private:

« no previous file with comments | « no previous file | extensions/renderer/api_test_base.h » ('j') | extensions/renderer/module_system_test.cc » ('J')