Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 502883002: NaCl SDK: Fixed getos.py crashing due to Git migration. (Closed)

Created:
6 years, 4 months ago by Matt Giuca
Modified:
6 years, 3 months ago
Reviewers:
Sam Clegg, binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NaCl SDK: Fixed getos.py crashing due to Git migration. Was trying to parse a Git commit hash as an int. getos --check-version no longer compares exact revision numbers, only major version numbers (because the Git hashes can't directly be compared, unlike SVN numbers). Added a TODO to compare Cr-Commit-Position when it becomes available. BUG=406993 Committed: https://crrev.com/ee69a3bdc3311bdda864a9e3e042aa382ef9996b Cr-Commit-Position: refs/heads/master@{#291888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M native_client_sdk/src/tools/getos.py View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Matt Giuca
6 years, 4 months ago (2014-08-25 07:22:04 UTC) #1
Sam Clegg
Seems ok to me. What to you think ben?
6 years, 4 months ago (2014-08-25 11:46:00 UTC) #2
Matt Giuca
I pinged Ben but he's not available today. Do we really need him to review ...
6 years, 4 months ago (2014-08-25 23:49:20 UTC) #3
Sam Clegg
lgtm
6 years, 4 months ago (2014-08-26 08:28:40 UTC) #4
Sam Clegg
thanks for fixing this by the way!
6 years, 4 months ago (2014-08-26 08:29:47 UTC) #5
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 4 months ago (2014-08-26 08:39:10 UTC) #6
Matt Giuca
No worries!
6 years, 4 months ago (2014-08-26 08:39:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/502883002/1
6 years, 4 months ago (2014-08-26 08:40:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (1) as 45c1b18ed9e301e40c6e3fa0000b57302a3f198f
6 years, 3 months ago (2014-08-26 11:53:37 UTC) #9
binji
lgtm, thanks!
6 years, 3 months ago (2014-08-26 17:17:21 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:42:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee69a3bdc3311bdda864a9e3e042aa382ef9996b
Cr-Commit-Position: refs/heads/master@{#291888}

Powered by Google App Engine
This is Rietveld 408576698