my_activity: Port gerrit to the new gerrit_util API.

my_activity.py

Index: my_activity.py
diff --git a/my_activity.py b/my_activity.py
index 3d73c8b1c3908853d714b14754f412203eb43ddd..83abd870ce77b96151419746d7d94736d3d7be87 100755
--- a/my_activity.py
+++ b/my_activity.py
@@ -26,6 +26,7 @@ import datetime
 from datetime import datetime
 from datetime import timedelta
 from functools import partial
+import gerrit_util
 import json
 import optparse
 import os
@@ -119,12 +120,10 @@ gerrit_instances = [
     'url': 'chromium-review.googlesource.com',
     'shorturl': 'crosreview.com',
   },
-  # TODO(deymo): chrome-internal-review requires login credentials. Enable once
-  # login support is added to this client. See crbug.com/281695.
-  #{
-  #  'url': 'chrome-internal-review.googlesource.com',
-  #  'shorturl': 'crosreview.com/i',
-  #},
+  {
+    'url': 'chrome-internal-review.googlesource.com',
+    'shorturl': 'crosreview.com/i',
+  },
   {
     'host': 'gerrit.chromium.org',
     'port': 29418,
@@ -405,27 +404,10 @@ class MyActivity(object):
 
   @staticmethod
   def gerrit_changes_over_rest(instance, filters):
-    # See https://gerrit-review.googlesource.com/Documentation/rest-api.html
-    # Gerrit doesn't allow filtering by created time, only modified time.
-    args = urllib.urlencode([
-        ('q', ' '.join(filters)),
-        ('o', 'MESSAGES'),
-        ('o', 'LABELS')])
-    rest_url = 'https://%s/changes/?%s' % (instance['url'], args)
-
-    req = urllib2.Request(rest_url, headers={'Accept': 'text/plain'})
-    try:
-      response = urllib2.urlopen(req)
-      stdout = response.read()
-    except urllib2.HTTPError, e:
-      print 'ERROR: Looking up %r: %s' % (rest_url, e)
-      return []
-
-    # Check that the returned JSON starts with the right marker.
-    if stdout[:5] != ")]}'\n":
-      print 'ERROR: Marker not found on REST API response: %r' % stdout[:5]
-      return []
-    return json.loads(stdout[5:])
+    # Convert the "key:value" filter to a dictionary.
+    req = dict(f.split(':', 1) for f in filters)
+    return gerrit_util.QueryAllChanges(instance['url'], req,

[Ryan Tseng, 2013/10/30 22:20:45]

Try/Catch gerrit_util.GerritError here, print the error like line 421 before the
change if caught (in case of 403), and exit cleanly (return [])

I think the behavior previously was to continue on 403, whereas this would just
throw and exit.

[deymo, 2013/10/30 22:32:31]

Agreed.

+        o_params=['MESSAGES', 'LABELS', 'DETAILED_ACCOUNTS'])
 
   def gerrit_search(self, instance, owner=None, reviewer=None):
     max_age = datetime.today() - self.modified_after
@@ -506,7 +488,8 @@ class MyActivity(object):
   @staticmethod
   def process_gerrit_rest_issue_replies(replies):
     ret = []
-    replies = filter(lambda r: 'email' in r['author'], replies)
+    replies = filter(lambda r: 'author' in r and 'email' in r['author'],
+        replies)
     for reply in replies:
       ret.append({
         'author': reply['author']['email'],