Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 502743002: Always enable optimize_jni_generation on non-WebView builds. (Closed)

Created:
6 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, Torne, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Always enable optimize_jni_generation on non-WebView builds. It seems that the cons are fairly weak and the benefits might be worth it. This flag breaks WebView builds. BUG=None Committed: https://crrev.com/23668752ea266ca59e788510fc9e4baaf0397895 Cr-Commit-Position: refs/heads/master@{#292458}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M build/android/developer_recommended_flags.gypi View 2 chunks +2 lines, -6 lines 0 comments Download
M build/common.gypi View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mlamouri (slow - plz ping)
6 years, 4 months ago (2014-08-23 11:45:21 UTC) #1
cjhopman
https://codereview.chromium.org/502743002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/502743002/diff/1/build/common.gypi#newcode987 build/common.gypi:987: }], You should set this to 0 in the ...
6 years, 3 months ago (2014-08-27 19:08:51 UTC) #2
mlamouri (slow - plz ping)
PTAL https://codereview.chromium.org/502743002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/502743002/diff/1/build/common.gypi#newcode987 build/common.gypi:987: }], On 2014/08/27 19:08:51, cjhopman wrote: > You ...
6 years, 3 months ago (2014-08-28 15:12:03 UTC) #3
cjhopman
lgtm
6 years, 3 months ago (2014-08-28 19:05:15 UTC) #4
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 3 months ago (2014-08-28 20:04:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/502743002/20001
6 years, 3 months ago (2014-08-28 20:06:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as cc7f3dcee8e7b00fb97eb71c49d4c2427e24714d
6 years, 3 months ago (2014-08-28 20:57:00 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:02:06 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/23668752ea266ca59e788510fc9e4baaf0397895
Cr-Commit-Position: refs/heads/master@{#292458}

Powered by Google App Engine
This is Rietveld 408576698