Issue 502733002: Eliminating FIXME from RenderFlexibleBox::mainAxisContentExtent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 502733002: Eliminating FIXME from RenderFlexibleBox::mainAxisContentExtent (Closed)

Created:
6 years, 4 months ago by harpreet.sk

Modified:
6 years, 3 months ago

Reviewers:
cbiesinger, leviw_travelin_and_unemployed, arpitabahuguna, eae, ojan

CC:
blink-reviews, cbiesinger, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Eliminating FIXME from RenderFlexibleBox::mainAxisContentExtent A FIXME was added in RenderFlexibleBox::mainAxisContentExtent as a part of the patch (https://bugs.webkit.org/attachment.cgi?id=193373&action=diff) stating: "Remove std::max once we enable saturated layout arithmetic." Since as per BUG=229103 SATURATED_LAYOUT_ARITHMETIC has been enabled for the chromiuim port so we can remove this std::max which was added to handle overflow. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180884

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	Source/core/rendering/RenderFlexibleBox.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/502733002/1

6 years, 4 months ago (2014-08-26 02:45:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 180884

Expand Messages | Collapse Messages