Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 502713003: Encode CEntryStub properties in the minor key. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Encode CEntryStub properties in the minor key. Eventually, all stubs should encode its properties in the minor key so that stubs can be restored directly from the stub key. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23355

Patch Set 1 #

Patch Set 2 : encode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -126 lines) Patch
M src/arm/code-stubs-arm.h View 7 chunks +7 lines, -7 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.h View 8 chunks +11 lines, -13 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 29 chunks +46 lines, -36 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.h View 9 chunks +9 lines, -9 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.h View 9 chunks +9 lines, -9 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M src/x87/code-stubs-x87.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 3 months ago (2014-08-25 12:21:33 UTC) #1
mvstanton
this is really nice, LGTM.
6 years, 3 months ago (2014-08-25 12:42:35 UTC) #2
Yang
6 years, 3 months ago (2014-08-25 13:09:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23355 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698