Issue 502693003: Cleanup DesktopMediaPicker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 502693003: Cleanup DesktopMediaPicker

Created:
6 years, 4 months ago by Sergey Ulanov

Modified:
6 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup DesktopMediaPicker Removed context and parent_window parameters from DesktopMediaPicker::Show() as they are no longer useful because implementations are now passed web_contents which can be used to get context for the dialog.

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -30 lines)			Patch
M	chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/media/desktop_media_picker.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm	View	1 chunk	+6 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/desktop_media_picker_views.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/desktop_media_picker_views.cc	View	3 chunks	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages