Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 502593002: Update the update_reference_builds script. (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
4 years, 12 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update the update_reference_builds script. The chrome-archive bucket is no longer updated and so we're pulling from chrome-unsigned instead. This patch also removes code for pulling from anywhere other than official builds. BUG=405792 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291560

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : Make version required #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -137 lines) Patch
M tools/update_reference_build.py View 1 2 8 chunks +37 lines, -137 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
tonyg
6 years, 4 months ago (2014-08-22 20:31:32 UTC) #1
qyearsley
https://codereview.chromium.org/502593002/diff/1/tools/update_reference_build.py File tools/update_reference_build.py (right): https://codereview.chromium.org/502593002/diff/1/tools/update_reference_build.py#newcode13 tools/update_reference_build.py:13: for SVN. You can do this by running: Will ...
6 years, 4 months ago (2014-08-22 22:06:15 UTC) #2
tonyg
https://codereview.chromium.org/502593002/diff/1/tools/update_reference_build.py File tools/update_reference_build.py (right): https://codereview.chromium.org/502593002/diff/1/tools/update_reference_build.py#newcode13 tools/update_reference_build.py:13: for SVN. You can do this by running: On ...
6 years, 4 months ago (2014-08-22 22:18:53 UTC) #3
qyearsley
On 2014/08/22 22:18:53, tonyg wrote: > https://codereview.chromium.org/502593002/diff/1/tools/update_reference_build.py > File tools/update_reference_build.py (right): > > https://codereview.chromium.org/502593002/diff/1/tools/update_reference_build.py#newcode13 > ...
6 years, 4 months ago (2014-08-22 22:23:41 UTC) #4
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-22 22:25:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/502593002/40001
6 years, 4 months ago (2014-08-22 22:26:06 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (40001) as 291560
6 years, 4 months ago (2014-08-22 23:55:17 UTC) #7
nojeenler.vik
5 years ago (2015-12-22 21:59:47 UTC) #9
qyearsley
4 years, 12 months ago (2015-12-28 17:29:33 UTC) #10
Message was sent while issue was closed.
On 2015/12/22 21:59:47, nojeenler.vik wrote:

Still lgtm (16 months after this patch was created...)

Powered by Google App Engine
This is Rietveld 408576698