Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 502583002: Exports gesture manager to a separate file and adds its unittests. (Closed)

Created:
6 years, 4 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Exports gesture manager to a separate file and adds its unittests. BUG=403813 R=sadrul@chromium.org TEST=athena_unittests Committed: https://crrev.com/c96ea8f3e111c9fc6c0f0b12f893e84289f40510 Cr-Commit-Position: refs/heads/master@{#291945}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -159 lines) Patch
M athena/athena.gyp View 1 2 chunks +5 lines, -0 lines 0 comments Download
M athena/home/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M athena/home/athena_start_page_view.cc View 5 chunks +4 lines, -6 lines 0 comments Download
A athena/home/home_card_constants.h View 1 chunk +20 lines, -0 lines 0 comments Download
A + athena/home/home_card_constants.cc View 1 chunk +3 lines, -6 lines 0 comments Download
A athena/home/home_card_gesture_manager.h View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
A athena/home/home_card_gesture_manager.cc View 1 2 1 chunk +115 lines, -0 lines 0 comments Download
A athena/home/home_card_gesture_manager_unittest.cc View 1 1 chunk +171 lines, -0 lines 0 comments Download
M athena/home/home_card_impl.cc View 1 3 chunks +2 lines, -147 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Jun Mukai
6 years, 4 months ago (2014-08-22 20:07:55 UTC) #1
sadrul
lgtm
6 years, 3 months ago (2014-08-26 15:53:59 UTC) #2
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 3 months ago (2014-08-26 16:12:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/502583002/40001
6 years, 3 months ago (2014-08-26 16:14:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 17:33:46 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-26 17:33:47 UTC) #6
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 3 months ago (2014-08-26 18:20:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/502583002/40001
6 years, 3 months ago (2014-08-26 18:21:38 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (40001) as 57f92a2c42f745d041290173ff5a10d54be0ee5b
6 years, 3 months ago (2014-08-26 18:36:05 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:44:13 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c96ea8f3e111c9fc6c0f0b12f893e84289f40510
Cr-Commit-Position: refs/heads/master@{#291945}

Powered by Google App Engine
This is Rietveld 408576698