Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 502533003: Revert of Add support for codepen to form_based_credentials_background (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
sullivan, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, dtu, jeremy, aiolos (Not reviewing)
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for codepen to form_based_credentials_background (patchset #9 of https://codereview.chromium.org/485743002/) Reason for revert: The test change is causing flakiness on trybots even with retries, see telemetry/core/backends/google_credentials_backend_unittest/TestGoogleCredentialsBackend/testLoginUsingMock: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5713 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5703 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6959 http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/9980 http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/9973 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/2974 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/2966 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6950 Original issue's description: > Add support for codepen to form_based_credentials_background > > Fix google credentials support. > > Migrate to action_runner when possible. > > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/a64e885edb85f66035f35a848c0add3726a663af TBR=tonyg@chromium.org,sullivan@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/aee4c9f50df8c0ab073c4313b292c3f5276d0b00 Cr-Commit-Position: refs/heads/master@{#291925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -133 lines) Patch
M tools/perf/page_sets/data/credentials.json.sha1 View 1 chunk +1 line, -1 line 0 comments Download
D tools/telemetry/telemetry/core/backends/codepen_credentials_backend.py View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/telemetry/telemetry/core/backends/codepen_credentials_backend_unittest.py View 1 chunk +0 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py View 1 chunk +4 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/facebook_credentials_backend_unittest.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py View 4 chunks +34 lines, -39 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py View 2 chunks +6 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/google_credentials_backend.py View 1 chunk +3 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/google_credentials_backend_unittest.py View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_credentials.py View 3 chunks +1 line, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_credentials_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Add support for codepen to form_based_credentials_background
6 years, 3 months ago (2014-08-26 17:20:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/502533003/1
6 years, 3 months ago (2014-08-26 17:21:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as c52c77ac119b370321edaeb3f8346887ecea31c8
6 years, 3 months ago (2014-08-26 17:22:59 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:43:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aee4c9f50df8c0ab073c4313b292c3f5276d0b00
Cr-Commit-Position: refs/heads/master@{#291925}

Powered by Google App Engine
This is Rietveld 408576698