Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issue 502503003: TestWebServer needs to use a free port. (Closed)

Created:
6 years, 4 months ago by hush (inactive)
Modified:
6 years, 3 months ago
Reviewers:
Yaron
CC:
chromium-reviews, cbentzel+watch_chromium.org, benm (inactive)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

TestWebServer needs to use a free port. Instead of a hardcoded port that could be taken. BUG= Committed: https://crrev.com/c4a3f88c4434e86057a8c7ae4e109b8be4138d8f Cr-Commit-Position: refs/heads/master@{#292014}

Patch Set 1 #

Patch Set 2 : style #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java View 1 2 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hush (inactive)
If you don't 4444 or 4445 port is taken on the device, you will get ...
6 years, 4 months ago (2014-08-22 18:18:17 UTC) #1
hush (inactive)
PTAL
6 years, 4 months ago (2014-08-23 00:55:33 UTC) #2
Yaron
On 2014/08/23 00:55:33, hush wrote: > PTAL Is there a bug for this? Are we ...
6 years, 4 months ago (2014-08-25 19:23:22 UTC) #3
hush (inactive)
On 2014/08/25 19:23:22, Yaron wrote: > On 2014/08/23 00:55:33, hush wrote: > > PTAL > ...
6 years, 4 months ago (2014-08-25 20:14:13 UTC) #4
Yaron
lgtm
6 years, 3 months ago (2014-08-26 17:52:24 UTC) #5
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 3 months ago (2014-08-26 20:56:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/502503003/40001
6 years, 3 months ago (2014-08-26 20:58:25 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (40001) as e5a72f7e4b9609aa111c90908cad7e44d5be73c0
6 years, 3 months ago (2014-08-26 22:53:26 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:46:48 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c4a3f88c4434e86057a8c7ae4e109b8be4138d8f
Cr-Commit-Position: refs/heads/master@{#292014}

Powered by Google App Engine
This is Rietveld 408576698