Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Issue 502503002: Revert of Move actions after browser Start in cros_browser_backend.Start to DidStart. (Closed)

Created:
6 years, 4 months ago by nednguyen
Modified:
6 years, 4 months ago
Reviewers:
achuithb, jennyz
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Move actions after browser Start in cros_browser_backend.Start to DidStart. (patchset #1 of https://codereview.chromium.org/499453002/) Reason for revert: The original patch of this (https://codereview.chromium.org/449753002/) broke chromeos bot in https://code.google.com/p/chromium/issues/detail?id=406010 Original issue's description: > Move actions after browser Start in cros_browser_backend.Start to DidStart. > > BUG=406010 > NOTRY=true > NOTREECHECKS=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291310 TBR=jennyz@chromium.org,achuith@chromium.org NOTREECHECKS=true NOTRY=true BUG=406010 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nednguyen
Created Revert of Move actions after browser Start in cros_browser_backend.Start to DidStart.
6 years, 4 months ago (2014-08-22 16:23:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/502503002/1
6 years, 4 months ago (2014-08-22 16:24:21 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 16:27:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 291426

Powered by Google App Engine
This is Rietveld 408576698