Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 502493004: Normalize away "./" when writing Ninja short rules. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/4ee32c2f8b7d2fd5a216a877b2b939fb4bad2ffa Cr-Commit-Position: refs/heads/master@{#291699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/gn/ninja_build_writer.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 4 months ago (2014-08-22 21:51:05 UTC) #1
jamesr
lgtm
6 years, 4 months ago (2014-08-22 21:52:50 UTC) #2
brettw
Committed patchset #1 to pending queue manually as 937e5b8 (presubmit successful).
6 years, 4 months ago (2014-08-25 16:52:49 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ee32c2f8b7d2fd5a216a877b2b939fb4bad2ffa
Cr-Commit-Position: refs/heads/master@{#291699}

Powered by Google App Engine
This is Rietveld 408576698