gm/multipicturedraw.cpp - Issue 502493002: Fix leak in multipicturedraw GMs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/multipicturedraw.cpp

Issue 502493002: Fix leak in multipicturedraw GMs. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/multipicturedraw.cpp

diff --git a/gm/multipicturedraw.cpp b/gm/multipicturedraw.cpp

index a030bccdbf668661f780df5798a72d44789e4ec8..2da1ab6c5dc6daee388484e2d2f1f11f4e63dd23 100644

--- a/gm/multipicturedraw.cpp

+++ b/gm/multipicturedraw.cpp

@@ -295,8 +295,8 @@ namespace skiagm {

const SkPicture* fPictures[2];

virtual void onOnceBeforeDraw() SK_OVERRIDE {

- fPictures[0] = SkRef(make_picture(SK_ColorWHITE));

- fPictures[1] = SkRef(make_picture(SK_ColorGRAY));

+ fPictures[0] = make_picture(SK_ColorWHITE);

+ fPictures[1] = make_picture(SK_ColorGRAY);

}

virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE{

« no previous file with comments | « no previous file | no next file » | no next file with comments »