Check policy when checking device access for enumerating devices.

Check policy when checking device access for enumerating devices.

* Move out MediaStreamDevicesController::GetDevicePolicy() to plain function in a helper file.
* Use that as a check in ProfileIOData::ResourceContext::Allow{Mic,Camera}Access().

BUG=406094

[tommi (sloooow) - chröme, 2014-08-22 19:42:57]

something about modifying ResourceContext gets me nervous :/

https://codereview.chromium.org/502483002/diff/20001/chrome/browser/media/med...
File chrome/browser/media/media_stream_devices_helper.cc (right):

https://codereview.chromium.org/502483002/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_stream_devices_helper.cc:37: GURL security_origin,
const GURL&

https://codereview.chromium.org/502483002/diff/20001/chrome/browser/media/med...
File chrome/browser/media/media_stream_devices_helper.h (right):

https://codereview.chromium.org/502483002/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_stream_devices_helper.h:12: enum
MediaStreamDevicePolicy {
should the contents of this file be in a namespace?

https://codereview.chromium.org/502483002/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_io_data.h (right):

https://codereview.chromium.org/502483002/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/profile_io_data.h:423: void set_profile(Profile*
profile);
I'm wary of making changes to ResourceContext and this one seems to be
potentially introducing circular references or the possibility of associating a
resource context to a profile that is not related to the io_data_.
If at all possible, I'd like to not make changes to this file.

https://codereview.chromium.org/502483002/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/profile_io_data.h:447: Profile* profile_;
this would need a lot of documentation I think and tests to go with it

[mmenke, 2014-08-22 20:08:52]

https://codereview.chromium.org/502483002/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_io_data.cc (right):

https://codereview.chromium.org/502483002/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/profile_io_data.cc:964: prefs::kAudioCaptureAllowedUrls)
== ALWAYS_ALLOW) {
Erm...Aren't we on the IO thread here, not the UI thread?

[Henrik Grunell, 2014-08-25 08:21:46]

https://codereview.chromium.org/502483002/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_io_data.h (right):

https://codereview.chromium.org/502483002/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/profile_io_data.h:423: void set_profile(Profile*
profile);
On 2014/08/22 19:42:56, tommi wrote:
> I'm wary of making changes to ResourceContext and this one seems to be
> potentially introducing circular references or the possibility of associating
a
> resource context to a profile that is not related to the io_data_.
> If at all possible, I'd like to not make changes to this file.

Maybe asking for access based on policy via RenderFrameHostDelegate instead, the
same route as RequestMediaAccessPermission currently takes? I'll also need to
add asking for app permission (in case of an extension), which should be done
via RenderFrameHostDelegate. So adding both there might make sense anyway. Wdyt?

[Henrik Grunell, 2014-08-28 15:25:34]

Closing this CL in favor of https://codereview.chromium.org/483523006/.