Issue 502473002: Teach benchmark runner to understand generic traces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 502473002: Teach benchmark runner to understand generic traces. (Closed)

Created:
6 years, 4 months ago by Michael Achenbach

Modified:
6 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Teach benchmark runner to understand generic traces. BUG=406405 LOG=n TEST=python -m unittest run_benchmarks_test R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23329

Patch Set 2 : #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -1 line)			Patch
	M	tools/run_benchmarks.py	View		4 chunks	+34 lines, -1 line	1 comment	Download
	M	tools/unittests/run_benchmarks_test.py	View		2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

PTAL https://codereview.chromium.org/502473002/diff/20001/tools/run_benchmarks.py File tools/run_benchmarks.py (right): https://codereview.chromium.org/502473002/diff/20001/tools/run_benchmarks.py#newcode316 tools/run_benchmarks.py:316: trace_result.traces[0]["stddev"] = stddev Note: Having multiple reruns by ...

6 years, 4 months ago (2014-08-22 14:41:27 UTC) #1

Michael Achenbach

6 years, 4 months ago (2014-08-24 14:32:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 23329 (presubmit successful).

Expand Messages | Collapse Messages

Issue 502473002: Teach benchmark runner to understand generic traces. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages