Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 50243005: ChromeOS: Remove unused IBus classes from chromeos/. (Closed)

Created:
7 years, 1 month ago by pneubeck (no reviews)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

ChromeOS: Remove unused IBus classes from chromeos/. BUG=171351 R=nona@chromium.org, satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233276

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressed comment, rebased. #

Patch Set 3 : Remove unnecessary includes. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1168 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine_ibus.h View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.cc View 1 5 chunks +12 lines, -13 lines 0 comments Download
M chromeos/chromeos.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 7 chunks +1 line, -62 lines 0 comments Download
M chromeos/dbus/fake_dbus_thread_manager.h View 5 chunks +0 lines, -18 lines 0 comments Download
M chromeos/dbus/fake_dbus_thread_manager.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M chromeos/dbus/ibus/ibus_client.h View 2 chunks +1 line, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_client.cc View 2 chunks +1 line, -166 lines 0 comments Download
D chromeos/dbus/ibus/ibus_client_unittest.cc View 1 chunk +0 lines, -411 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_factory_service.h View 2 chunks +1 line, -4 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_factory_service.cc View 1 chunk +2 lines, -7 lines 0 comments Download
D chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc View 1 chunk +0 lines, -232 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/ime/ibus_daemon_controller.cc View 2 chunks +1 line, -211 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pneubeck (no reviews)
7 years, 1 month ago (2013-11-03 20:19:03 UTC) #1
satorux1
pneubeck, thank you for working on this! +komatsu and +nona who were also planning to ...
7 years, 1 month ago (2013-11-05 03:37:55 UTC) #2
Seigo Nonaka
lgtm, thank you for taking!
7 years, 1 month ago (2013-11-06 02:03:58 UTC) #3
pneubeck (no reviews)
https://codereview.chromium.org/50243005/diff/60001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): https://codereview.chromium.org/50243005/diff/60001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode57 chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:57: ibus_engine_factory_service_.reset(IBusEngineFactoryService::Create()); On 2013/11/05 03:37:55, satorux1 wrote: > do this ...
7 years, 1 month ago (2013-11-06 09:07:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/50243005/280001
7 years, 1 month ago (2013-11-06 09:09:48 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on chromium_presubmit HTTP Error 400: Bad Request
7 years, 1 month ago (2013-11-06 09:17:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/50243005/360001
7 years, 1 month ago (2013-11-06 09:17:25 UTC) #7
pneubeck (no reviews)
On 2013/11/06 09:17:25, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 1 month ago (2013-11-06 09:26:38 UTC) #8
satorux1
lgtm
7 years, 1 month ago (2013-11-06 09:47:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/50243005/360001
7 years, 1 month ago (2013-11-06 14:17:01 UTC) #10
pneubeck (no reviews)
7 years, 1 month ago (2013-11-06 16:12:40 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 manually as r233276 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698