runtime/bin/vmservice/client/lib/src/observatory_elements/json_view.dart - Issue 50243002: Extend Observatory to display libraries, classes, fields, functions and code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/json_view.dart

Issue 50243002: Extend Observatory to display libraries, classes, fields, functions and code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/json_view.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/json_view.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/json_view.dart

index 80ee10b10d4b4c2bc639159c0c7b1608a9450099..8aca30dc4c44c6e6c3532301e3e867d27fc5bf39 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/json_view.dart

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/json_view.dart

@@ -9,14 +9,18 @@ import 'observatory_element.dart';

@CustomTag('json-view')

class JsonViewElement extends ObservatoryElement {

- @published dynamic get json => __$json; dynamic __$json = null; set json(dynamic value) { __$json = notifyPropertyChange(#json, __$json, value); }

+ @published var json = null;

var _count = 0;

- JsonViewElement() : super() {

+ JsonViewElement.created() : super.created();

+ void enteredView() {

+ super.enteredView();

+ _count = 0;

}

void jsonChanged(oldValue) {

- this.notifyPropertyChange(#valueType, null, null);

+ notifyPropertyChange(#valueType, "a", "b");

}

String get primitiveString {