Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 5024002: Avoid a kernel driver / X server crash situation. (Closed)

Created:
8 years, 3 months ago by bfreed
Modified:
7 years, 5 months ago
Reviewers:
marcheu1, Daniel Erat
CC:
chromium-os-reviews_chromium.org, sosa
Visibility:
Public.

Description

Avoid a kernel driver / X server crash situation. Change the order of our calls to xrandr to mask a situation that can cause the GPU to hang, i915 driver to give up, and the X server to crash. This crash is not recoverable and requires a reboot. BUG=chromium-os:6701 TEST=manual: [Un]Plug VGA, then hit Ctrl-F4. Repeat... This workaround changes the order of xrandr calls from: xrandr --output LVDS1 --mode 1280x800 xrandr --output VGA1 --off xrandr --fb 1280x800 to: xrandr --output VGA1 --off xrandr --fb 1280x800 xrandr --output LVDS1 --mode 1280x800 In my experimentation, turning on LVDS later makes a big difference. But it is not perfect. I have still seen the failure, but it is much harder to reproduce. Change-Id: I300887ef2c65173bafeccd8afdf657f91f71c736 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e6cd2a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M monitor_reconfigure_main.cc View 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bfreed
8 years, 3 months ago (2010-11-15 23:21:04 UTC) #1
Daniel Erat
Interesting. :-) LGTM!
8 years, 3 months ago (2010-11-16 00:16:13 UTC) #2
marcheu1
On Mon, Nov 15, 2010 at 16:16, <derat@chromium.org> wrote: > Interesting. :-) LGTM! > > ...
8 years, 3 months ago (2010-11-16 01:58:04 UTC) #3
bfreed
Please share your driver patch. I am very interested in testing it. I am leaning ...
8 years, 3 months ago (2010-11-17 21:53:28 UTC) #4
marcheu1
8 years, 3 months ago (2010-11-18 22:16:55 UTC) #5
Hi,

Okay, the issue here is more complex than I thought... I have a number of
fixes for the intel driver but they don't fix this one. I'll investigate
further, as I can reproduce here. In the meantime, I think you should push
the workaround.

Stéphane

Powered by Google App Engine
This is Rietveld 408576698