Issue 5024: Avoid locking cert_lock_ again from the same thread....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5024: Avoid locking cert_lock_ again from the same thread.... (Closed)

Created:
12 years, 2 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
jcampan, jar (doing other things)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't use cert_lock_ as a reentrant lock. RemoveCert is renamed RemoveCertInternal to stress the fact that it should be called with the lock held. Fix miscellaneous nits complained by cpplint. R=jcampan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2677

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -15 lines)			Patch
	M	chrome/browser/cert_store.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/cert_store.cc	View		4 chunks	+12 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages