Move WebSocket masking benchmarks to net_perftests

Move WebSocket masking benchmarks to net_perftests

Previously WebSocketFrameTestMaskBenchmark.* were included in
net_unittests (with a small number of iterations to avoid slowing down
testing). Move them to net_perftests.

Also remove the command-line option to control the number of iterations,
and use the standard base::PerfTimeLogger output instead of custom logging.

BUG=407445
TEST=net_unittests, net_perftests

Committed: https://crrev.com/b2ab006098714c5b96b2c816b9e969f38bad3825
Cr-Commit-Position: refs/heads/master@{#292856}

[Adam Rice, 2014-08-27 06:55:27]

ricea@chromium.org changed reviewers:
+ yhirano@chromium.org

[yhirano, 2014-08-27 07:22:33]

https://codereview.chromium.org/502353002/diff/20001/net/websockets/websocket...
File net/websockets/websocket_frame_perftest.cc (right):

https://codereview.chromium.org/502353002/diff/20001/net/websockets/websocket...
net/websockets/websocket_frame_perftest.cc:53: scoped_ptr<char[]> payload(new
char[kLongPayloadSize]);
How about using std::vector<char> payload(kLongPayloadSize, 'a') ?

[Adam Rice, 2014-08-27 07:39:42]

https://codereview.chromium.org/502353002/diff/20001/net/websockets/websocket...
File net/websockets/websocket_frame_perftest.cc (right):

https://codereview.chromium.org/502353002/diff/20001/net/websockets/websocket...
net/websockets/websocket_frame_perftest.cc:53: scoped_ptr<char[]> payload(new
char[kLongPayloadSize]);
On 2014/08/27 07:22:33, yhirano wrote:
> How about using std::vector<char> payload(kLongPayloadSize, 'a') ?

Done.

[yhirano, 2014-08-27 07:53:24]

lgtm

[Adam Rice, 2014-08-28 02:24:17]

ricea@chromium.org changed reviewers:
+ rvargas@chromium.org

[Adam Rice, 2014-08-28 02:24:17]

+rvargas Sorry for the trouble. PTAL.

[rvargas (doing something else), 2014-08-28 17:59:30]

lgtm after the nit, thanks!

https://codereview.chromium.org/502353002/diff/40001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/502353002/diff/40001/net/net.gyp#newcode881
net/net.gyp:881: # The websockets/ directory is not compiled in on iOS.
nit: the comment seems unrelated to what the condition is checking. It seems
better to remove it.

Also, the indentation of this block is off.

[Adam Rice, 2014-08-29 17:24:19]

https://codereview.chromium.org/502353002/diff/40001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/502353002/diff/40001/net/net.gyp#newcode881
net/net.gyp:881: # The websockets/ directory is not compiled in on iOS.
On 2014/08/28 17:59:30, rvargas wrote:
> nit: the comment seems unrelated to what the condition is checking. It seems
> better to remove it.
> 
> Also, the indentation of this block is off.

I removed the comment. I'm confused about what the indentation should be here.
Emacs thinks it should be two spaces, but the other places in the file that have
similar constructs use four spaces.

[rvargas (doing something else), 2014-08-29 18:27:16]

Thanks

https://codereview.chromium.org/502353002/diff/40001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/502353002/diff/40001/net/net.gyp#newcode881
net/net.gyp:881: # The websockets/ directory is not compiled in on iOS.
On 2014/08/29 17:24:19, Adam Rice wrote:
> On 2014/08/28 17:59:30, rvargas wrote:
> > nit: the comment seems unrelated to what the condition is checking. It seems
> > better to remove it.
> > 
> > Also, the indentation of this block is off.
> 
> I removed the comment. I'm confused about what the indentation should be here.
> Emacs thinks it should be two spaces, but the other places in the file that
have
> similar constructs use four spaces.

Interesting. I think it should be 2 spaces and some other places in this file
have the wrong indentation. For example, lines 869-875 indentation is correct
against  868-876, but 868-878 is wrong against 867-879, most likely as a result
of moving blocks around :(. More to the point, 870-874 is correct and it
corresponds to this exact pattern.

[Adam Rice, 2014-09-01 08:09:30]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2014-09-01 08:09:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ricea@chromium.org/502353002/80001

[commit-bot: I haz the power, 2014-09-01 09:04:56]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-09-01 10:00:53]

Committed patchset #5 (id:80001) as dea9ed7407958c5c46d660024bcef167fe1aca01

[commit-bot: I haz the power, 2014-09-10 03:16:19]

Patchset 5 (id:??) landed as
https://crrev.com/b2ab006098714c5b96b2c816b9e969f38bad3825
Cr-Commit-Position: refs/heads/master@{#292856}