Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: components/signin/core/browser/signin_manager.cc

Issue 502343002: Add account_id to signin manager notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@isauth
Patch Set: Fix android trybots Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_manager.cc
diff --git a/components/signin/core/browser/signin_manager.cc b/components/signin/core/browser/signin_manager.cc
index 710c21ff1def3022b771d3038ac59a9c8202eda4..cd4978e5eac19b03f4629cd97e88531dea7fcb3c 100644
--- a/components/signin/core/browser/signin_manager.cc
+++ b/components/signin/core/browser/signin_manager.cc
@@ -201,6 +201,7 @@ void SigninManager::SignOut(
ClearTransientSigninData();
+ const std::string account_id = GetAuthenticatedAccountId();
const std::string username = GetAuthenticatedUsername();
const base::Time signin_time =
base::Time::FromInternalValue(
@@ -227,7 +228,9 @@ void SigninManager::SignOut(
<< "IsSigninAllowed: " << IsSigninAllowed();
token_service_->RevokeAllCredentials();
- FOR_EACH_OBSERVER(Observer, observer_list_, GoogleSignedOut(username));
+ FOR_EACH_OBSERVER(Observer,
+ observer_list_,
+ GoogleSignedOut(account_id, username));
}
void SigninManager::Initialize(PrefService* local_state) {
@@ -373,9 +376,13 @@ void SigninManager::OnSignedIn(const std::string& username) {
FOR_EACH_OBSERVER(
Observer,
observer_list_,
- GoogleSigninSucceeded(GetAuthenticatedUsername(), password_));
+ GoogleSigninSucceeded(GetAuthenticatedAccountId(),
+ GetAuthenticatedUsername(),
+ password_));
- client_->GoogleSigninSucceeded(GetAuthenticatedUsername(), password_);
+ client_->GoogleSigninSucceeded(GetAuthenticatedAccountId(),
+ GetAuthenticatedUsername(),
+ password_);
signin_metrics::LogSigninProfile(client_->IsFirstRun(),
client_->GetInstallDate());
« no previous file with comments | « components/signin/core/browser/signin_client.h ('k') | components/signin/core/browser/signin_manager_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698