chrome/browser/metrics/signin_status_metrics_provider.cc - Issue 502343002: Add account_id to signin manager notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/signin_status_metrics_provider.cc

Issue 502343002: Add account_id to signin manager notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@isauth

Patch Set: Fix android trybots Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/signin_status_metrics_provider.cc

diff --git a/chrome/browser/metrics/signin_status_metrics_provider.cc b/chrome/browser/metrics/signin_status_metrics_provider.cc

index d334df1267ee28385c00194f111e801b488ed1d7..70b94a41abbab73a1829f80adf9c567b0b3e8034 100644

--- a/chrome/browser/metrics/signin_status_metrics_provider.cc

+++ b/chrome/browser/metrics/signin_status_metrics_provider.cc

@@ -120,13 +120,15 @@ void SigninStatusMetricsProvider::SigninManagerShutdown(

}

void SigninStatusMetricsProvider::GoogleSigninSucceeded(

+ const std::string& account_id,

const std::string& username,

const std::string& password) {

if (signin_status_ == ALL_PROFILES_NOT_SIGNED_IN)

signin_status_ = MIXED_SIGNIN_STATUS;

}

-void SigninStatusMetricsProvider::GoogleSignedOut(const std::string& username) {

+void SigninStatusMetricsProvider::GoogleSignedOut(const std::string& account_id,

+ const std::string& username) {

if (signin_status_ == ALL_PROFILES_SIGNED_IN)

signin_status_ = MIXED_SIGNIN_STATUS;

}