Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: components/signin/core/browser/signin_manager_base.h

Issue 502343002: Add account_id to signin manager notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@isauth
Patch Set: rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/signin/core/browser/signin_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/browser/signin_manager_base.h
diff --git a/components/signin/core/browser/signin_manager_base.h b/components/signin/core/browser/signin_manager_base.h
index 2d3ca43c44746e7df494708c3c6454e0554cee14..a7a0f9b6feba6082e6fa388588334353c9698182 100644
--- a/components/signin/core/browser/signin_manager_base.h
+++ b/components/signin/core/browser/signin_manager_base.h
@@ -48,11 +48,13 @@ class SigninManagerBase : public KeyedService {
virtual void GoogleSigninFailed(const GoogleServiceAuthError& error) {}
// Called when a user signs into Google services such as sync.
- virtual void GoogleSigninSucceeded(const std::string& username,
+ virtual void GoogleSigninSucceeded(const std::string& account_id,
+ const std::string& username,
const std::string& password) {}
// Called when the currently signed-in user for a user has been signed out.
- virtual void GoogleSignedOut(const std::string& username) {}
+ virtual void GoogleSignedOut(const std::string& account_id,
+ const std::string& username) {}
guohui 2014/08/27 17:57:42 Why have both account_id and username in the signa
Roger Tawa OOO till Jul 10th 2014/08/27 18:51:01 Because that would require observers to keep a poi
protected:
virtual ~Observer() {}
« no previous file with comments | « components/signin/core/browser/signin_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698