Add account_id to signin manager notifications.

Add account_id to signin manager notifications.

BUG=341408
TBR=TBR=bauerb@chromium.org, benwells@chromium.org, gene@chromium.org, asvitkine@chromium.org, noms@chromium.org, tim@chromium.org, sky@chromium.org, fgorski@chromium.org

Committed: https://crrev.com/22aa58e63b325a6fbdea7f59ce9b0b6e63ac96cc
Cr-Commit-Position: refs/heads/master@{#292635}

[Roger Tawa OOO till Jul 10th, 2014-08-27 13:12:16]

Patchset #1 (id:1) has been deleted

[Roger Tawa OOO till Jul 10th, 2014-08-27 13:12:25]

Patchset #1 (id:20001) has been deleted

[Roger Tawa OOO till Jul 10th, 2014-08-27 13:12:34]

Patchset #1 (id:40001) has been deleted

[Roger Tawa OOO till Jul 10th, 2014-08-27 13:18:02]

Patchset #1 (id:60001) has been deleted

[Roger Tawa OOO till Jul 10th, 2014-08-27 13:54:39]

rogerta@chromium.org changed reviewers:
+ guohui@chromium.org

[Roger Tawa OOO till Jul 10th, 2014-08-27 13:54:39]

Hi Hui,

Please take look.  Some cleanup needed for gaia id migration.  Thanks.

[guohui, 2014-08-27 17:57:42]

lgtm with one comment

https://codereview.chromium.org/502343002/diff/100001/components/signin/core/...
File components/signin/core/browser/signin_manager_base.h (right):

https://codereview.chromium.org/502343002/diff/100001/components/signin/core/...
components/signin/core/browser/signin_manager_base.h:57: const std::string&
username) {}
Why have both account_id and username in the signature? account_id is supposed
to uniquely identify a user and it could always be converted to username using
AccountTrackerService when necessary. So isn't it cleaner to have account_id
only?

[Roger Tawa OOO till Jul 10th, 2014-08-27 18:51:01]

Thanks Hui.

https://codereview.chromium.org/502343002/diff/100001/components/signin/core/...
File components/signin/core/browser/signin_manager_base.h (right):

https://codereview.chromium.org/502343002/diff/100001/components/signin/core/...
components/signin/core/browser/signin_manager_base.h:57: const std::string&
username) {}
On 2014/08/27 17:57:42, guohui wrote:
> Why have both account_id and username in the signature? account_id is supposed
> to uniquely identify a user and it could always be converted to username using
> AccountTrackerService when necessary. So isn't it cleaner to have account_id
> only?

Because that would require observers to keep a pointer to the Profile* so that
they could access AccountTrackerService.  In one case that does not happen
(SigninNamesOnIOThread).  Also, I think its better to pass both to the event
than have one come in as an arg and the other have to be fetched from a PKS.

[Roger Tawa OOO till Jul 10th, 2014-08-27 22:03:08]

Patchset #4 (id:140001) has been deleted

[Roger Tawa OOO till Jul 10th, 2014-08-28 02:34:09]

Patchset #4 (id:160001) has been deleted

[Roger Tawa OOO till Jul 10th, 2014-08-29 12:50:34]

rogerta@chromium.org changed reviewers:
+ asvitkine@chromium.org, bauerb@chromium.org, benwells@chromium.org,
fgorski@chromium.org, gene@chromium.org, noms@chromium.org, sky@chromium.org,
tim@chromium.org

[Roger Tawa OOO till Jul 10th, 2014-08-29 14:18:01]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2014-08-29 14:18:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rogerta@chromium.org/502343002/260001

[Alexei Svitkine (slow), 2014-08-29 14:20:38]

lgtm

[commit-bot: I haz the power, 2014-08-29 15:16:05]

Committed patchset #8 (id:260001) as ba9f8e3518040b15356660a51489b461965f02a5

[commit-bot: I haz the power, 2014-09-10 03:08:43]

Patchset 8 (id:??) landed as
https://crrev.com/22aa58e63b325a6fbdea7f59ce9b0b6e63ac96cc
Cr-Commit-Position: refs/heads/master@{#292635}