Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: media/cast/sender/audio_sender.h

Issue 502333002: [Cast] In Audio/VideoSender, drop frames when too-long a duration is in-flight. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Based on TimeDelta rather than RTP delta. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/sender/audio_sender.h
diff --git a/media/cast/sender/audio_sender.h b/media/cast/sender/audio_sender.h
index e07b892a73eadd6b40c1fff3629ea540972f1b18..c7080ccbe20dee8fed2aaca74940c461d51965fb 100644
--- a/media/cast/sender/audio_sender.h
+++ b/media/cast/sender/audio_sender.h
@@ -64,11 +64,11 @@ class AudioSender : public FrameSender,
void ResendCheck();
void ResendForKickstart();
- // Returns true if there are too many frames in flight, as defined by the
- // configured target playout delay plus simple logic. When this is true,
- // InsertAudio() will silenty drop frames instead of sending them to the audio
- // encoder.
- bool AreTooManyFramesInFlight() const;
+ // Returns true if there are too many frames in flight, or if the media
+ // duration of the frames in flight would be too high by sending the next
+ // frame. The latter metric is determined from the given |capture_time|
+ // for the next frame to be encoded and sent.
+ bool ShouldDropNextFrame(base::TimeTicks capture_time) const;
// Called by the |audio_encoder_| with the next EncodedFrame to send.
void SendEncodedAudioFrame(scoped_ptr<EncodedFrame> audio_frame);

Powered by Google App Engine
This is Rietveld 408576698