Allow filing a bug from the "Link Bug" dialog

Tools/GardeningServer/ui/ct-failure-card.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="ct-builder-grid.html">
 <link rel="import" href="ct-commit-list.html">
 <link rel="import" href="ct-test-list.html">
 <link rel="import" href="../bower_components/paper-dialog/paper-dialog.html">
@@ skipping 43 matching lines @@
 
       #failure {
         flex: 1;
       }
 
       #buttons {
         display: flex;
         flex-direction: column;
       }
 
+      #bugReminder {
+        font-size: large;
+        color: red;
+      }
+
       .snoozed {
         opacity: 0.5;
       }
     </style>
-    <ct-builder-grid failures="{{ group.failures }}"></ct-builder-grid>
+    <ct-builder-grid failures="{{ group.failures }}" id="builderGrid"></ct-builder-grid>
     <div id="failure" class="{{ { snoozed: group.isSnoozed } | tokenList }}">
       <ct-test-list tests="{{ group.failures }}" tree="{{ tree }}"></ct-test-list>
       <ct-commit-list commitList="{{ _commitList }}"></ct-commit-list>
     </div>
     <div id="buttons">
       <paper-button id="examine" on-tap="{{ examine }}" label="Examine"></paper-button>
       <template if="{{ !group.isSnoozed }}">
         <paper-button id="snooze" on-tap="{{ snooze }}" label="Snooze"></paper-button>
       </template>
       <template if="{{ group.isSnoozed }}">
         <paper-button id="snooze" on-tap="{{ unsnooze }}" label="Unsnooze"></paper-button>
       </template>
       <paper-button id="link-bug" on-tap="{{ linkBug }}" label="Link Bug"></paper-button>
       <template if="{{ group.bug !== undefined }}">
         <div>
           <a href="{{ group.bug }}">
             {{ group.bugLabel }}</a>
         </div>
       </template>
     </div>
 
     <paper-dialog heading="Enter bug number" transition="paper-transition-center" id="bugDialog">
       <paper-input label="Bug# or URL" floatingLabel autofocus id="bug"></paper-input>
+      <div><a id="fileBugLink" target="_new" on-click="{{ fileBugClicked }}">File bug</a></div>

[ojan, 2014/08/26 03:14:17]

What's _new do? I've always done _blank.

[cbiesinger, 2014/09/11 06:24:34]

Sigh, I misremembered the name. Fixed.

+      <div style="display: hidden" id="bugReminder">

[ojan, 2014/08/26 03:14:17]

Instead of toggling display with script, just wrap each of these in a <template
if>? You still need the onclick to set the member variable I suppose. Not sure
if it's better or worse.

[cbiesinger, 2014/09/11 06:24:34]

Done.

[cbiesinger, 2014/09/29 21:18:06]

FYI I did this but had to move the template inside the <a>. Otherwise, toggling
the member variable will make the <a> disappear before the link click can open
the window (at least, that's what I think is happening).

+        Remember to enter the new bug number above!
+      </div>
       <paper-button label="Remove bug link" on-tap="{{ removeBug }}" dismissive id="dialogRemoveBug"></paper-button>
       <paper-button label="OK" on-tap="{{ saveBug }}" affirmative id="dialogOk"></paper-button>
     </paper-dialog>
   </template>
   <script>
     Polymer({
       group: null,
       commitLog: null,
       tree: '',
       _commitList: null,
+      _fileBugUrl: 'https://code.google.com/p/chromium/issues/entry?' +
+          'status=Available&labels=Pri-2,gardening-blink&' +
+          'summary=Build%20failure&comment=Build%20is%20broken:%0a',

[ojan, 2014/08/26 03:14:17]

Lets leave the summary out of this. google code has a dumb bug where it will
clear this value when you click on it. It's super annoying.

[cbiesinger, 2014/09/11 06:24:34]

Done.

 
       observe: {
         group: '_updateCommitList',
         commitLog: '_updateCommitList'
       },
 
       examine: function() {
         this.fire('ct-examine-failures', this.group);
       },
 
       snooze: function() {
         this.group.snoozeUntil(Date.now() + 60 * 60 * 1000);
       },
 
       unsnooze: function() {
         this.group.unsnooze();
       },
 
       _updateCommitList: function() {
         this._commitList = this.group ?
             this.group.commitList(this.commitLog) : undefined;
       },
 
       linkBug: function() {
+        var message = '';

[ojan, 2014/08/26 03:14:17]

Can you move the function that generates this url (and _fileBugUrl) into
CTFailureGroup? You can pass it the commitLog as an argument to that function
for now, although probably we should just have a setCommitLog function on
CTFailureGroup so that we don't need to pass it in in multiple places.

[cbiesinger, 2014/09/11 06:24:34]

I thought about that, but I'm really not sure that it belongs in the model
class. Isn't this link generation more of a UI thing, especially figuring out
exactly what the message should be?

But if you really want me to move it, I can.

[ojan, 2014/09/11 23:44:25]

Maybe you don't need to move the url generation to a helper, but you probably
should move the message generation. As an example, we're going to add a revert
button for changes and we'll want to share the message generation code.

+        for (var i = 0; i < this.group.failures.length; ++i) {

[ojan, 2014/08/26 03:14:17]

Here and below, use forEach?

[cbiesinger, 2014/09/11 06:24:34]

Done.

+          var failure = this.group.failures[i];
+          message += failure.step;
+          if (failure.testName) {
+            message += ' ' + failure.testName + '\n';
+            message += failure.flakinessDashboardURL(this.tree);
+          }
+          message += '\n';
+        }
+        message += '\nRevision range:\n';
+        for (i = 0; i < this._commitList.repositories.length; ++i) {
+          var repository = this._commitList.repositories[i];
+          message += repository.name + ' ' + repository.range + '\n';
+        }
+        message += '\nFailing builders:\n';
+        for (i = 0; i < this.$.builderGrid.builders.length; ++i) {
+          var builder = this.$.builderGrid.builders[i];
+          message += builder.builder + ': ' + builder.buildUrl + '\n';
+        }
+
         this.$.bug.value = this.group.bug;
+        this.$.fileBugLink.href = this._fileBugUrl + encodeURIComponent(message);
+        this.$.bugReminder.style.display = 'none';
+        this.$.fileBugLink.style.display = '';
         this.$.bugDialog.toggle();
       },
 
       saveBug: function() {
         this.group.setBug(this.$.bug.value);
       },
 
       removeBug: function() {
         this.group.clearBug();
       },
+
+      fileBugClicked: function() {
+        this.$.bugReminder.style.display = '';
+        this.$.fileBugLink.style.display = 'none';
+      },
     });
   </script>
 </polymer-element>