chrome/browser/devtools/device/port_forwarding_controller.cc - Issue 502293002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/devtools/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/port_forwarding_controller.cc

Issue 502293002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/android_device_manager.cc ('k') | chrome/browser/devtools/device/usb/android_usb_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/port_forwarding_controller.cc

diff --git a/chrome/browser/devtools/device/port_forwarding_controller.cc b/chrome/browser/devtools/device/port_forwarding_controller.cc

index df610d199221fb35357ad699cf2d8bae1ccd4be0..2fff9f28b3a313ebe096c2dac833f8705bd67984 100644

--- a/chrome/browser/devtools/device/port_forwarding_controller.cc

+++ b/chrome/browser/devtools/device/port_forwarding_controller.cc

@@ -574,7 +574,7 @@ void PortForwardingController::DeviceListChanged(

if (rit == registry_.end()) {

scoped_refptr<DevToolsAndroidBridge::RemoteBrowser> browser =

FindBestBrowserForTethering(device->browsers());

- if (browser) {

+ if (browser.get()) {

new Connection(&registry_, device, browser, forwarding_map_);

}

} else {