chrome/browser/devtools/device/android_device_manager.cc - Issue 502293002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/devtools/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/android_device_manager.cc

Issue 502293002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/adb/mock_adb_server.cc ('k') | chrome/browser/devtools/device/port_forwarding_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/android_device_manager.cc

diff --git a/chrome/browser/devtools/device/android_device_manager.cc b/chrome/browser/devtools/device/android_device_manager.cc

index 9020d60939f78161101129cbddffc789638760d7..10978be731dcc0153798c2649fcc7c7ed48fa75d 100644

--- a/chrome/browser/devtools/device/android_device_manager.cc

+++ b/chrome/browser/devtools/device/android_device_manager.cc

@@ -487,8 +487,8 @@ void AndroidDeviceManager::UpdateDevices(

++it) {

DeviceWeakMap::iterator found = devices_.find(it->serial);

scoped_refptr<Device> device;

- if (found == devices_.end() || !found->second

- || found->second->provider_ != it->provider) {

+ if (found == devices_.end() || !found->second ||

+ found->second->provider_.get() != it->provider.get()) {

device = new Device(handler_thread_->message_loop(),

it->provider, it->serial);

} else {