Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 502273002: Revert "Move core web_view code to extensions." (patchset #6 of https://codereview.chromium.org/4968 (Closed)

Created:
6 years, 4 months ago by James Cook
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tfarina, jam, stuartmorgan+watch_chromium.org, Michael van Ouwerkerk, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Move core web_view code to extensions." (patchset #6 of https://codereview.chromium.org/496873006/) This reverts commit 63bf863b12e8c2be593da2318af8ab7c7fbcc8a4. This breaks the app_shell build for the reasons jamesr describes (src/extensions now depends on generated headers from src/chrome, but there cannot be a dependency from extensions -> chrome). Hypothetical repro on Linux: * rm -rf out/* && gclient runhooks && ninja -C out/Debug -j 1000 app_shell chrome/browser/extensions/api/capture_web_contents_function.h:9:10: fatal error: 'chrome/common/extensions/api/types.h' file not found Original issue's description: > Move core web_view code to extensions. > > > BUG=352290 > > Committed: https://chromium.googlesource.com/chromium/src/+/1218a23163baab9f53d70e9a63030db13ef04d04 TBR=fsamuel@chromium.org,yoz@chromium.org,kalman@chromium.org,sky@chromium.org,dmazzoni@chromium.org,jamesr@chromium.org,hanxi@chromium.org NOTREECHECKS=true NOTRY=true BUG=352290 Committed: https://crrev.com/196564d93b1ed77487eb570b2ab74e7adc3af8ef Cr-Commit-Position: refs/heads/master@{#291808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -3283 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 3 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_view/web_view_internal_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_view/web_view_internal_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/url_request_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_extensions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 6 chunks +9 lines, -41 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc View 8 chunks +12 lines, -10 lines 0 comments Download
A + chrome/browser/guest_view/web_view/javascript_dialog_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/guest_view/web_view/javascript_dialog_helper.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_find_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_find_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_guest.h View 2 chunks +8 lines, -11 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_guest.cc View 5 chunks +37 lines, -11 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_permission_helper.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_permission_helper.cc View 2 chunks +8 lines, -7 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_permission_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_renderer_state.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_renderer_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +15 lines, -2 lines 0 comments Download
M extensions/browser/api/extensions_api_client.h View 2 chunks +0 lines, -15 lines 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D extensions/browser/guest_view/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D extensions/browser/guest_view/web_view/javascript_dialog_helper.h View 1 chunk +0 lines, -57 lines 0 comments Download
D extensions/browser/guest_view/web_view/javascript_dialog_helper.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D extensions/browser/guest_view/web_view/web_view_constants.h View 1 chunk +0 lines, -118 lines 0 comments Download
D extensions/browser/guest_view/web_view/web_view_constants.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D extensions/browser/guest_view/web_view/web_view_find_helper.h View 1 chunk +0 lines, -190 lines 0 comments Download
D extensions/browser/guest_view/web_view/web_view_find_helper.cc View 1 chunk +0 lines, -282 lines 0 comments Download
D extensions/browser/guest_view/web_view/web_view_guest.h View 1 chunk +0 lines, -363 lines 0 comments Download
D extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +0 lines, -1105 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest_delegate.h View 4 chunks +1 line, -10 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
D extensions/browser/guest_view/web_view/web_view_permission_helper.h View 1 chunk +0 lines, -161 lines 0 comments Download
D extensions/browser/guest_view/web_view/web_view_permission_helper.cc View 1 chunk +0 lines, -347 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h View 3 chunks +1 line, -9 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc View 1 chunk +2 lines, -6 lines 0 comments Download
D extensions/browser/guest_view/web_view/web_view_permission_types.h View 1 chunk +0 lines, -38 lines 0 comments Download
D extensions/browser/guest_view/web_view/web_view_renderer_state.h View 1 chunk +0 lines, -77 lines 0 comments Download
D extensions/browser/guest_view/web_view/web_view_renderer_state.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +8 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Cook
jamescook@chromium.org changed reviewers: + mukai@chromium.org
6 years, 4 months ago (2014-08-26 00:22:17 UTC) #1
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-26 00:22:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/502273002/1
6 years, 4 months ago (2014-08-26 00:25:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (1) as b83b8a78f292eee43663c4c329cc0bfa59f199e9
6 years, 4 months ago (2014-08-26 00:29:48 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:39:17 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/196564d93b1ed77487eb570b2ab74e7adc3af8ef
Cr-Commit-Position: refs/heads/master@{#291808}

Powered by Google App Engine
This is Rietveld 408576698