Adding histogram to count number of RTTs for handshake when confirmation is required.

Adding histogram to count number of RTTs for handshake when confirmation is required.

BUG=411476
Committed: https://crrev.com/5d4f2af9a63ff2bbf24a0baccc2b22952582f20a
Cr-Commit-Position: refs/heads/master@{#292182}

[Jana, 2014-08-25 23:50:02]

jri@chromium.org changed reviewers:
+ asvitkine@chromium.org, rch@chromium.org

[Ryan Hamilton, 2014-08-26 16:50:24]

lgtm

https://codereview.chromium.org/502243002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/502243002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:54165: <suffix name="ForHTTP"
label="Only insecure HTTP connections are counted."/>
nit: I notice that the name of this suffix is QuicRttCount but it seems like
something like QuicConnectionType (or some such) would be a better choice?

[Jana, 2014-08-26 17:22:08]

Thanks Ryan, nit addressed.  
[Alexei: Apologies if it wasn't clear earlier -- I have added you as a reviewer.
Just a heads-up.]

https://codereview.chromium.org/502243002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/502243002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:54165: <suffix name="ForHTTP"
label="Only insecure HTTP connections are counted."/>
On 2014/08/26 16:50:24, Ryan Hamilton wrote:
> nit: I notice that the name of this suffix is QuicRttCount but it seems like
> something like QuicConnectionType (or some such) would be a better choice?

Yeah -- I noticed it too, and now that we've both noticed it, I've changed it
per your suggestion :-)

[Alexei Svitkine (slow), 2014-08-26 20:22:58]

asvitkine@chromium.org changed reviewers:
+ jwd@chromium.org

[Alexei Svitkine (slow), 2014-08-26 20:22:58]

I'm OOO right now, +jwd for histograms review.

[jwd, 2014-08-27 15:18:28]

lgtm

[Alexei Svitkine (slow), 2014-08-27 15:31:15]

lgtm per jwd's review

[Jana, 2014-08-27 15:57:17]

Thanks much! Committing.

[Jana, 2014-08-27 15:57:27]

The CQ bit was checked by jri@chromium.org

[commit-bot: I haz the power, 2014-08-27 15:58:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jri@chromium.org/502243002/20001

[commit-bot: I haz the power, 2014-08-27 17:24:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-27 18:10:54]

Committed patchset #2 (id:20001) as 49862c6f1886f1a76f3ba3febfb3ac68b7b3052b

[commit-bot: I haz the power, 2014-09-10 02:52:40]

Patchset 2 (id:??) landed as
https://crrev.com/5d4f2af9a63ff2bbf24a0baccc2b22952582f20a
Cr-Commit-Position: refs/heads/master@{#292182}